chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java - Issue 1606043004: Remove dismissForEachType() from SnackbarController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java

Issue 1606043004: Remove dismissForEachType() from SnackbarController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/smartlockautosignin/AutoSigninSnackbarController.java ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java

index a50683d224efc404861abb41c3b78c8aea643cd5..2ab3a8b12da10715a6e2cf3db2bd20f12737a801 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java

@@ -41,8 +41,6 @@ public class UndoBarPopupController implements SnackbarManager.SnackbarControlle

private static final int TAB_CLOSE_UNDO_TOAST_SHOWN_COLD = 0;

private static final int TAB_CLOSE_UNDO_TOAST_SHOWN_WARM = 1;

private static final int TAB_CLOSE_UNDO_TOAST_PRESSED = 2;

- private static final int TAB_CLOSE_UNDO_TOAST_DISMISSED_TIMEOUT = 3;

- private static final int TAB_CLOSE_UNDO_TOAST_DISMISSED_ACTION = 4;

private static final int TAB_CLOSE_UNDO_TOAST_COUNT = 5;

private final TabModelSelector mTabModelSelector;

@@ -193,12 +191,4 @@ public class UndoBarPopupController implements SnackbarManager.SnackbarControlle

TabModel model = mTabModelSelector.getModelForTabId(tabId);

if (model != null) model.commitTabClosure(tabId);

}

- @Override

- public void onDismissForEachType(boolean isTimeout) {

- RecordHistogram.recordEnumeratedHistogram("AndroidTabCloseUndo.Toast",

- isTimeout ? TAB_CLOSE_UNDO_TOAST_DISMISSED_TIMEOUT

- : TAB_CLOSE_UNDO_TOAST_DISMISSED_ACTION,

- TAB_CLOSE_UNDO_TOAST_COUNT);

- }

}