Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1606013003: SkNx miplevel building (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkNx miplevel building All sizes approximately twice as fast. Before: micros bench 1649.35 mipmap_build_512x512 nonrendering 1824.42 mipmap_build_511x512 nonrendering 2100.66 ? mipmap_build_512x511 nonrendering 2375.94 mipmap_build_511x511 nonrendering After: micros bench 730.32 ! mipmap_build_512x512 nonrendering 922.12 mipmap_build_511x512 nonrendering 999.07 mipmap_build_512x511 nonrendering 1342.93 ! mipmap_build_511x511 nonrendering BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606013003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/3bd5aba2a0e165997f683cf3aa306661e71464f6 Committed: https://skia.googlesource.com/skia/+/550e9b0ef1c0fba42e2e902a467af322ad2413da

Patch Set 1 #

Patch Set 2 : neon #

Patch Set 3 : refine note #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -3 lines) Patch
M src/core/SkMipMap.cpp View 5 chunks +15 lines, -3 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 2 2 chunks +47 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606013003/1
4 years, 11 months ago (2016-01-19 19:39:31 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/5406)
4 years, 11 months ago (2016-01-19 19:40:10 UTC) #6
mtklein_C
Ignore the red ARM bots..
4 years, 11 months ago (2016-01-19 19:53:22 UTC) #8
reed1
lgtm
4 years, 11 months ago (2016-01-19 20:05:07 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606013003/40001
4 years, 11 months ago (2016-01-19 20:07:45 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 20:18:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606013003/40001
4 years, 11 months ago (2016-01-19 20:19:26 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/3bd5aba2a0e165997f683cf3aa306661e71464f6
4 years, 11 months ago (2016-01-19 20:20:05 UTC) #18
mtklein
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1607323002/ by mtklein@google.com. ...
4 years, 11 months ago (2016-01-20 16:33:49 UTC) #19
mtklein
On 2016/01/20 16:33:49, mtklein wrote: > A revert of this CL (patchset #3 id:40001) has ...
4 years, 11 months ago (2016-01-20 19:02:44 UTC) #20
mtklein_C
On 2016/01/20 at 19:02:44, mtklein wrote: > On 2016/01/20 16:33:49, mtklein wrote: > > A ...
4 years, 11 months ago (2016-01-20 19:55:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606013003/40001
4 years, 11 months ago (2016-01-20 19:55:26 UTC) #23
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 19:55:53 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/550e9b0ef1c0fba42e2e902a467af322ad2413da

Powered by Google App Engine
This is Rietveld 408576698