Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1606: hodgepodge for test_shell.cc (Closed)

Created:
12 years, 3 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Visibility:
Public.

Description

This is my work in progress to get TestShell working. It doesn't work yet, and it also includes a bunch of other patches that I've already uploaded as other reviews, so I expect it to get smaller as they are committed. The plan is to have a general TestShell with a pointer to a platform-specific TestShellImpl. The test_shell_gtk.h TestShellImpl shows what an empty one might look like. The test_shell_win.h one obviously won't work. Places marked XXX I intend to fix before sending this out; places marked TODO(port) or NOTIMPLEMENTED I intend to put off until after committing.

Patch Set 1 #

Patch Set 2 : update some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -473 lines) Patch
M base/gfx/native_widget_types.h View 1 chunk +4 lines, -0 lines 0 comments Download
M build/SConscript.main View 2 chunks +6 lines, -3 lines 0 comments Download
M net/url_request/url_request_filter.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/bspatch/SConscript View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/SConscript View 2 chunks +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/SConscript View 3 chunks +119 lines, -103 lines 0 comments Download
M webkit/tools/test_shell/run_all_tests.cc View 4 chunks +9 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 7 chunks +21 lines, -13 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 31 chunks +91 lines, -335 lines 0 comments Download
A webkit/tools/test_shell/test_shell_gtk.h View 1 chunk +58 lines, -0 lines 0 comments Download
A webkit/tools/test_shell/test_shell_win.h View 1 chunk +47 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 6 chunks +23 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/webview_host.h View 2 chunks +10 lines, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host.h View 5 chunks +22 lines, -7 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698