Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: build/SConscript.main

Issue 1606: hodgepodge for test_shell.cc (Closed)
Patch Set: update some comments Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/gfx/native_widget_types.h ('k') | net/url_request/url_request_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/SConscript.main
diff --git a/build/SConscript.main b/build/SConscript.main
index 85631071107b5dbaac0d84e567b73bdb2e49afb9..5d4ace6bc36fa335691ca30ff312e70c2ef0eb55 100644
--- a/build/SConscript.main
+++ b/build/SConscript.main
@@ -338,6 +338,7 @@ elif env['PLATFORM'] == 'posix':
excluded_warnings = [
'-Wno-unknown-pragmas', # TODO: remove all the Windows-specific #pragmas.
'-Wno-unused-function', # TODO: there's just one Skia function.
+ '-Wno-unused-variable', # TODO: there's just one v8 function.
'-Wno-switch', # TODO: this is likely masking real bugs.
'-Wno-sign-compare', # TODO: this is likely masking real bugs.
'-Wno-missing-braces', # TODO: just a file in net.
@@ -345,11 +346,13 @@ elif env['PLATFORM'] == 'posix':
# Not TODO: This is technically nonstandard, but a lot of the image
# decoding code depends on it and osx wants this.
'-Wno-multichar',
+
+ '-Wno-deprecated', # Needed for using ext/hash_map on GCC 4.3
+ '-Wno-reorder', # TODO: many tedious small fixes.
]
env.Replace(
- CCFLAGS = ['-m32', '-g', '-pthread', '-Wall', '-Werror'] + excluded_warnings,
- # Needed for using ext/hash_map on GCC 4.3
- CXXFLAGS = ['-Wno-deprecated'],
+ CCFLAGS = ['-m32', '-g', '-pthread'],
+ CXXFLAGS = ['-Wall', '-Werror'] + excluded_warnings,
LINKFLAGS = ['-m32', '-pthread'],
# We need rt for clock_gettime.
LIBS = ['rt'],
« no previous file with comments | « base/gfx/native_widget_types.h ('k') | net/url_request/url_request_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698