Pass the correct value for the available width to updateLogicalWidthForAlignment() after placing an…

Pass the correct value for the available width to updateLogicalWidthForAlignment() after placing an ellipsis

The current code passes the right end of the line (normally equal to blockRightEdge) to
updateLogicalWidthForAlignment() after placing the ellipsis string for a truncated text with
'text-overflow: ellipsis', instead of passing the actual width between the left and right edges.

That mistake causes that left padding and border, when they exist, are not being properly taking
into account for ellipsized text, resulting in updateLogicalWidthForAlignment() thinking that
the value for availableLogicalWidth is bigger than what it actually is, thus misplacing the text
inside the container block after the adjustment.

Additionally, this patch renames one variable and changes the shape of the formula for RTL text
in RenderBlockFlow::checkLinesForTextOverflow(), to make it more readable and understandable.

BUG=166258, 166263
TEST=Added new test to ensure ellipsis is properly drawn for blocks with border and padding set.
R=tkent@chromium.org, dglazkov@chromium.org, eae@chromium.org, eseidel@chromium.org, leviw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167194

[mario.prada, 2014-02-12 17:29:07]

I think this patch fixes the issue with the ellipsized text as described in bugs
166258 and 166263.

Please review. Thanks!

[eae, 2014-02-14 10:29:10]

On 2014/02/12 17:29:07, mario.prada wrote:
> I think this patch fixes the issue with the ellipsized text as described in
bugs
> 166258 and 166263.
> 
> Please review. Thanks!

This is a great change, thanks for doing this!

I don't suppose there's anyway we could make the test a ref test instead?

Either way, LGTM

[eae, 2014-02-14 10:38:56]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-02-14 10:39:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mario.prada@samsung.com/160583002/1

[commit-bot: I haz the power, 2014-02-14 10:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 10:39:15]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1087.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
252c3131e9022fc6ba8aa85f46e3c212c2534879..6b64e1afb52ff61cd55b12055ed6113917efbc6f
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1087,3 +1087,12 @@ crbug.com/338148 [ Mac Mavericks SnowLeopard Lion
MountainLion Retina ] editing/
 crbug.com/338148 [ Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/insert-div-024.html [ NeedsRebaseline ]
 crbug.com/338148 [ Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/insert-div-026.html [ NeedsRebaseline ]
 crbug.com/338148 [ Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/deleting/delete-4083333-fix.html [ NeedsRebaseline ]
+
+# Needs rebaselining after fixing issue with text-overflow: ellipsis (not
showing up).
+crbug.com/166263 fast/css/text-overflow-ellipsis-text-align-center.html [
NeedsRebaseline ]
+crbug.com/166263 fast/css/text-overflow-ellipsis-text-align-left.html [
NeedsRebaseline ]
+crbug.com/166263 fast/css/text-overflow-ellipsis-text-align-right.html [
NeedsRebaseline ]
+crbug.com/166263
fast/css/vertical-text-overflow-ellipsis-text-align-center.html [
NeedsRebaseline ]
+crbug.com/166263 fast/css/vertical-text-overflow-ellipsis-text-align-left.html
[ NeedsRebaseline ]
+crbug.com/166263 fast/css/vertical-text-overflow-ellipsis-text-align-right.html
[ NeedsRebaseline ]
+crbug.com/166263
fast/css/text-overflow-ellipsis-block-with-border-and-padding.html [
NeedsRebaseline ]
\ No newline at end of file

[mario.prada, 2014-02-14 10:48:57]

Rebase patch against master

[eae, 2014-02-14 10:53:07]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-02-14 10:53:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mario.prada@samsung.com/160583002/90001

[commit-bot: I haz the power, 2014-02-14 11:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 11:45:38]

Retried try job too often on win_blink_rel for step(s) blink_heap_unittests,
blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests,
webkit_unit_tests, wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[eae, 2014-02-14 11:51:24]

On 2014/02/14 11:45:38, I haz the power (commit-bot) wrote:
> Retried try job too often on win_blink_rel for step(s) blink_heap_unittests,
> blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests,
> webkit_unit_tests, wtf_unittests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

Hmm, lets try again.

[eae, 2014-02-14 11:51:31]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-02-14 11:51:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mario.prada@samsung.com/160583002/90001

[commit-bot: I haz the power, 2014-02-14 11:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 11:51:55]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 955.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
77d169381934575c336bbcb7cc4ab1956288f120..32a30957492b1d4314e5043602153c33e42562e5
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -955,3 +955,12 @@ crbug.com/340105
svg/dom/svgpath-out-of-bounds-getPathSeg.html [ NeedsManualReba
 crbug.com/340105
virtual/deferred/fast/images/support-broken-image-delegate.html [
NeedsManualRebaseline ]
 
 crbug.com/329786 http/tests/inspector/network/network-shared-worker.html [ Pass
Failure ]
+
+# Needs rebaselining after fixing issue with text-overflow: ellipsis (not
showing up).
+crbug.com/166263 fast/css/text-overflow-ellipsis-text-align-center.html [
NeedsRebaseline ]
+crbug.com/166263 fast/css/text-overflow-ellipsis-text-align-left.html [
NeedsRebaseline ]
+crbug.com/166263 fast/css/text-overflow-ellipsis-text-align-right.html [
NeedsRebaseline ]
+crbug.com/166263
fast/css/vertical-text-overflow-ellipsis-text-align-center.html [
NeedsRebaseline ]
+crbug.com/166263 fast/css/vertical-text-overflow-ellipsis-text-align-left.html
[ NeedsRebaseline ]
+crbug.com/166263 fast/css/vertical-text-overflow-ellipsis-text-align-right.html
[ NeedsRebaseline ]
+crbug.com/166263
fast/css/text-overflow-ellipsis-block-with-border-and-padding.html [
NeedsRebaseline ]

[mario.prada, 2014-02-14 12:00:17]

Rebased patch again against master

[eae, 2014-02-14 12:01:33]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-02-14 12:01:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mario.prada@samsung.com/160583002/310001

[commit-bot: I haz the power, 2014-02-14 13:50:37]

Change committed as 167194