Move alternate 404 error page loading out of WebFrame and into RenderView....

Move alternate 404 error page loading out of WebFrame and into RenderView.

This involved adding a new method on WebViewDelegate to allow the embedder to
intercept data being loaded for a document.

I also had to plumb a few more FrameLoaderClient notifications through
WebViewDelegate.  See DidReceiveResponse and DidFinishLoading.

R=tony
BUG=15648
TEST=covered by errorpage_uitest.cc


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22389

[tony, 2009-08-04 17:07:44]

LGTM!

http://codereview.chromium.org/160578/diff/29/1056
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/160578/diff/29/1056#newcode2979
Line 2979: html_to_load = &navigation_state->postponed_data();
Ah, good catch about showing the original error page.

[darin (slow to review), 2009-08-04 17:34:48]

http://codereview.chromium.org/160578/diff/29/1056
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/160578/diff/29/1056#newcode2979
Line 2979: html_to_load = &navigation_state->postponed_data();
On 2009/08/04 17:07:45, tony wrote:
> Ah, good catch about showing the original error page.

The existing code for alt404 already handled this.  See the old code in
WebFrameLoaderClientImpl::Alt404PageFinished.  

In the case of other alt error pages, LoadNavigationErrorPage already deals with
an empty html string by constructing a default error page from original_error.