Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: webkit/glue/webframeloaderclient_impl.h

Issue 160578: Move alternate 404 error page loading out of WebFrame and into RenderView.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/webframeloaderclient_impl.h
===================================================================
--- webkit/glue/webframeloaderclient_impl.h (revision 22283)
+++ webkit/glue/webframeloaderclient_impl.h (working copy)
@@ -1,32 +1,20 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef WEBKIT_GLUE_WEBFRAMELOADERCLIENT_IMPL_H__
-#define WEBKIT_GLUE_WEBFRAMELOADERCLIENT_IMPL_H__
+#ifndef WEBKIT_GLUE_WEBFRAMELOADERCLIENT_IMPL_H_
+#define WEBKIT_GLUE_WEBFRAMELOADERCLIENT_IMPL_H_
#include "FrameLoaderClient.h"
#include <wtf/RefPtr.h>
-#include "base/scoped_ptr.h"
#include "googleurl/src/gurl.h"
#include "webkit/api/public/WebNavigationPolicy.h"
#include "webkit/glue/webview_delegate.h"
-namespace WebCore {
-class Frame;
-class HTMLFormElement;
-class Widget;
-}
-
-namespace webkit_glue {
-class AltErrorPageResourceFetcher;
-}
-
class WebFrameImpl;
class WebPluginContainer;
-
class WebFrameLoaderClient : public WebCore::FrameLoaderClient {
public:
WebFrameLoaderClient(WebFrameImpl* webframe);
@@ -204,12 +192,6 @@
virtual void registerForIconNotification(bool listen = true);
private:
- // Callback function for download of alternate 404 pages. If the server is
- // down or we take too long to download the page, |html| will be empty.
- void Alt404PageFinished(WebFrame* frame,
- const WebKit::WebURLError& original_error,
- const std::string& html);
-
void makeDocumentView();
// Given a NavigationAction, determine the associated WebNavigationPolicy.
@@ -218,9 +200,6 @@
const WebCore::NavigationAction& action,
WebKit::WebNavigationPolicy* policy);
- // Returns a valid GURL if we have an alt 404 server URL.
- GURL GetAlt404PageUrl(WebCore::DocumentLoader* loader);
-
// Returns NavigationGestureAuto if the last load was not user initiated,
// otherwise returns NavigationGestureUnknown.
NavigationGesture NavigationGestureForLastLoad();
@@ -232,12 +211,6 @@
// the web frame object is guaranteed to exist.
WebFrameImpl* webframe_;
- // Resource fetcher for downloading an alternate 404 page.
- scoped_ptr<webkit_glue::AltErrorPageResourceFetcher> alt_404_page_fetcher_;
-
- bool postpone_loading_data_;
- std::string postponed_data_;
-
// True if makeRepresentation was called. We don't actually have a concept
// of a "representation", but we need to know when we're expected to have one.
// See finishedLoading().
@@ -263,4 +236,4 @@
WebKit::WebNavigationPolicy next_navigation_policy_;
};
-#endif // #ifndef WEBKIT_GLUE_WEBFRAMELOADERCLIENT_IMPL_H__
+#endif // #ifndef WEBKIT_GLUE_WEBFRAMELOADERCLIENT_IMPL_H_

Powered by Google App Engine
This is Rietveld 408576698