Issue 1605763007: Validate that int values that we write to summaries are >= 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1605763007: Validate that int values that we write to summaries are >= 0. (Closed)

Created:
4 years, 11 months ago by scheglov

Modified:
4 years, 11 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Validate that int values that we write to summaries are >= 0. Also make tweaks for TestTypeProvider to ensure that this is true. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0a495243c606a314cd9ac5d12f5f974d9bde3b2e

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -11 lines)			Patch
M	pkg/analyzer/lib/src/generated/testing/element_factory.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/test_type_provider.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.dart	View	36 chunks	+36 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_elements.dart	View	2 chunks	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/tool/summary/generate.dart	View	2 chunks	+13 lines, -3 lines	0 comments	Download

Total messages: 5 (1 generated)

scheglov

4 years, 11 months ago (2016-01-20 21:38:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0a495243c606a314cd9ac5d12f5f974d9bde3b2e (presubmit successful).