Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: pkg/analyzer/lib/src/generated/testing/test_type_provider.dart

Issue 1605763007: Validate that int values that we write to summaries are >= 0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
diff --git a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
index 6f211908e23a84611f484f465c300881562205fb..3281405605957433d957b3f0a4ae3b30fcbc5563 100644
--- a/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
+++ b/pkg/analyzer/lib/src/generated/testing/test_type_provider.dart
@@ -182,7 +182,7 @@ class TestTypeProvider implements TypeProvider {
ClassElementImpl deprecatedElement =
ElementFactory.classElement2("Deprecated");
ConstructorElementImpl constructor = ElementFactory
- .constructorElement(deprecatedElement, null, true, [stringType]);
+ .constructorElement(deprecatedElement, '', true, [stringType]);
constructor.constantInitializers = <ConstructorInitializer>[
AstFactory.constructorFieldInitializer(
true, 'expires', AstFactory.identifier3('expires'))
@@ -274,7 +274,7 @@ class TestTypeProvider implements TypeProvider {
ElementFactory.getterElement("last", false, eType)
]);
iterableElement.constructors = <ConstructorElement>[
- ElementFactory.constructorElement(iterableElement, null, true)
+ ElementFactory.constructorElement(iterableElement, '', true)
..isCycleFree = true
];
_propagateTypeArguments(iterableElement);
@@ -343,7 +343,7 @@ class TestTypeProvider implements TypeProvider {
.methodElement("[]=", VoidTypeImpl.instance, [kType, vType])
];
mapElement.constructors = <ConstructorElement>[
- ElementFactory.constructorElement(mapElement, null, false)
+ ElementFactory.constructorElement(mapElement, '', false)
..external = true
..factory = true
];
@@ -397,7 +397,7 @@ class TestTypeProvider implements TypeProvider {
ClassElementImpl objectElement = ElementFactory.object;
_objectType = objectElement.type;
ConstructorElementImpl constructor =
- ElementFactory.constructorElement(objectElement, null, true);
+ ElementFactory.constructorElement(objectElement, '', true);
constructor.constantInitializers = <ConstructorInitializer>[];
objectElement.constructors = <ConstructorElement>[constructor];
objectElement.methods = <MethodElement>[
@@ -476,7 +476,7 @@ class TestTypeProvider implements TypeProvider {
if (_symbolType == null) {
ClassElementImpl symbolClass = ElementFactory.classElement2("Symbol");
ConstructorElementImpl constructor = ElementFactory
- .constructorElement(symbolClass, null, true, [stringType]);
+ .constructorElement(symbolClass, '', true, [stringType]);
constructor.factory = true;
constructor.isCycleFree = true;
symbolClass.constructors = <ConstructorElement>[constructor];
« no previous file with comments | « pkg/analyzer/lib/src/generated/testing/element_factory.dart ('k') | pkg/analyzer/lib/src/summary/format.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698