Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 16057002: Fixed position elements should layout relative to transformed container (Closed)

Created:
7 years, 7 months ago by trchen
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Fixed position elements should layout relative to transformed container The original layer coordinates conversion code contains a bug that it forgets to return for the simple case where the fixed position container found is already the ancestor layer wanted, and the code falls through to the special path intended for RenderFlowThread. R=jchaffraix@chromium.org BUG=243967 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153254

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Patch Set 3 : update image expectation too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/compositing/gestures/gesture-tapHighlight-simple-div-boxshadow-fixed-nested2-expected.png View 1 2 Binary file 0 comments Download
A LayoutTests/fast/block/positioning/fixed-position-transformed-container.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/positioning/fixed-position-transformed-container-expected.html View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
trchen
Hello Julien, this one-line patch fixes a fixed position layout bug. PTAL. Thanks!
7 years, 7 months ago (2013-05-25 03:50:05 UTC) #1
Julien - ping for review
Sorry for the delay, was gardening and didn't check my review queue. LGTM! https://codereview.chromium.org/16057002/diff/1/LayoutTests/fast/block/positioning/fixed-position-transformed-container.html File ...
7 years, 6 months ago (2013-05-29 19:53:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/16057002/11001
7 years, 5 months ago (2013-06-28 19:18:17 UTC) #3
commit-bot: I haz the power
Can't process patch for file LayoutTests/compositing/gestures/gesture-tapHighlight-simple-div-boxshadow-fixed-nested2-expected.png. Binary file support is temporarilly disabled due to a ...
7 years, 5 months ago (2013-06-28 19:18:18 UTC) #4
trchen
7 years, 5 months ago (2013-06-28 19:22:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r153254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698