Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1605513005: Fix bug where multiple JSObject wrappers could be created for the same JsObject. (Closed)

Created:
4 years, 11 months ago by Jacob
Modified:
4 years, 11 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug where multiple JSObject wrappers could be created for the same JsObject. Factory constructors for JSObject now set the _dartHtmlWrapper of the JsObject so that it will be hard to have future bugs related to preserving JSObject. BUG= Committed: https://github.com/dart-lang/sdk/commit/c66c110b750000f411853a9d4dff9ca747b00291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M sdk/lib/js/dartium/js_dartium.dart View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
TBR
4 years, 11 months ago (2016-01-19 18:59:29 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as c66c110b750000f411853a9d4dff9ca747b00291.
4 years, 11 months ago (2016-01-19 18:59:39 UTC) #4
Alan Knight
4 years, 11 months ago (2016-01-19 19:03:15 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698