Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: sdk/lib/js/dartium/js_dartium.dart

Issue 1605513005: Fix bug where multiple JSObject wrappers could be created for the same JsObject. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/js/dartium/js_dartium.dart
diff --git a/sdk/lib/js/dartium/js_dartium.dart b/sdk/lib/js/dartium/js_dartium.dart
index 5456924fc749cc23888b8705e5892ca636e79eac..d2b1f39e194963e5c665f1da40a254b7e6293912 100644
--- a/sdk/lib/js/dartium/js_dartium.dart
+++ b/sdk/lib/js/dartium/js_dartium.dart
@@ -672,19 +672,25 @@ abstract class JSObjectInterfacesDom $implementsClauseDom {
patch class JSObject {
factory JSObject.create(JsObject jsObject) {
- return new JSObjectImpl.internal()..blink_jsObject = jsObject;
+ var ret = new JSObjectImpl.internal()..blink_jsObject = jsObject;
+ jsObject._dartHtmlWrapper = ret;
+ return ret;
}
}
patch class JSFunction {
factory JSFunction.create(JsObject jsObject) {
- return new JSFunctionImpl.internal()..blink_jsObject = jsObject;
+ var ret = new JSFunctionImpl.internal()..blink_jsObject = jsObject;
+ jsObject._dartHtmlWrapper = ret;
+ return ret;
}
}
patch class JSArray {
factory JSArray.create(JsObject jsObject) {
- return new JSArrayImpl.internal()..blink_jsObject = jsObject;
+ var ret = new JSArrayImpl.internal()..blink_jsObject = jsObject;
+ jsObject._dartHtmlWrapper = ret;
+ return ret;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698