Correctly handle multiple control responses for RETR command.

Correctly handle multiple control responses for RETR command.

Re-enable tests which were intermittently failing before this fix and remove
debugging code used to track down the issue.

TEST=Covered by net_unittests.
http://crbug.com/18036

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22500

[wtc, 2009-08-04 23:46:30]

LGTM!

http://codereview.chromium.org/160537/diff/1/3
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/160537/diff/1/3#newcode135
Line 135: FtpCtrlResponse response = ctrl_response_buffer_.PopResponse();
Should this function empty ctrl_response_buffer_ before it
returns an error?  This seems to be required by the new
DCHECK you added to FtpNetworkTransaction::SendFtpCommand.

[Paweł Hajdan Jr., 2009-08-05 18:37:07]

On Tue, Aug 4, 2009 at 16:46, <wtc@chromium.org> wrote:

> http://codereview.chromium.org/160537/diff/1/3#newcode135
> Line 135: FtpCtrlResponse response =
> ctrl_response_buffer_.PopResponse();
> Should this function empty ctrl_response_buffer_ before it
> returns an error?  This seems to be required by the new
> DCHECK you added to FtpNetworkTransaction::SendFtpCommand.


This is a valid problem. However, in that case we hit other DCHECK first:

[24925:24925:0805/113345:786735128127:FATAL:/chromium/src/net/ftp/ftp_network_transaction.cc(310)]
Check failed: rv == OK.

I'm going to handle that in a separate issue. The code should call Stop
earlier or something like that I think.