Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: net/ftp/ftp_ctrl_response_buffer.cc

Issue 160537: Correctly handle multiple control responses for RETR command. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/ftp/ftp_network_transaction.cc » ('j') | net/ftp/ftp_network_transaction.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_ctrl_response_buffer.cc
diff --git a/net/ftp/ftp_ctrl_response_buffer.cc b/net/ftp/ftp_ctrl_response_buffer.cc
index 02f990873ecc5a99a5104472f0d0b053301c5269..b60ae816bc35ad4a57bddd0cd8cab5d909162769 100644
--- a/net/ftp/ftp_ctrl_response_buffer.cc
+++ b/net/ftp/ftp_ctrl_response_buffer.cc
@@ -8,19 +8,6 @@
#include "base/string_util.h"
#include "net/base/net_errors.h"
-namespace {
-
-// TODO(phajdan.jr): Remove when http://crbug.com/18036 is diagnosed.
-void LogResponse(const net::FtpCtrlResponse& response) {
- DLOG(INFO) << "received response with code " << response.status_code;
- for (std::vector<std::string>::const_iterator i = response.lines.begin();
- i != response.lines.end(); ++i) {
- DLOG(INFO) << "line [" << *i << "]";
- }
-}
-
-} // namespace
-
namespace net {
// static
@@ -44,7 +31,6 @@ int FtpCtrlResponseBuffer::ConsumeData(const char* data, int data_length) {
} else {
response_buf_.status_code = line.status_code;
response_buf_.lines.push_back(line.status_text);
- LogResponse(response_buf_);
responses_.push(response_buf_);
// Prepare to handle following lines.
@@ -64,7 +50,6 @@ int FtpCtrlResponseBuffer::ConsumeData(const char* data, int data_length) {
if (!line.is_multiline) {
response_buf_.lines.push_back(line_buf_);
- LogResponse(response_buf_);
responses_.push(response_buf_);
// Prepare to handle following lines.
« no previous file with comments | « no previous file | net/ftp/ftp_network_transaction.cc » ('j') | net/ftp/ftp_network_transaction.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698