Issue 25514. Harden parents validation in incremental resolver.

Issue 25514. Harden parents validation in incremental resolver.

R=brianwilkerson@google.com, skybrian@google.com
BUG= https://github.com/dart-lang/sdk/issues/25514

Committed: https://github.com/dart-lang/sdk/commit/23e9fbcf3041d2b0a089f128b2841750c3020786

[skybrian, 2016-01-20 06:29:50]

skybrian@google.com changed reviewers:
+ skybrian@google.com

[skybrian, 2016-01-20 06:29:50]

lgtm

Might this fix other bugs as well?

https://codereview.chromium.org/1605263002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/1605263002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:1471: List<AstNode>
oldParents = _getParents(oldNode);
It would be clearer to rename the function to _getAncestors.

[Brian Wilkerson, 2016-01-20 14:53:56]

LGTM

https://codereview.chromium.org/1605263002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/incremental_resolver_test.dart (right):

https://codereview.chromium.org/1605263002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/incremental_resolver_test.dart:3919: void
test_false_constructor_initializer() {
Given the number of new cases that appear to have been added, I was expecting
more new tests. Do these really cover all the cases (such as class
declarations)?

[scheglov, 2016-01-20 16:02:09]

Description was changed from

==========
Issue 25514. Harden parents validation in incremental resolver.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25514
==========

to

==========
Issue 25514. Harden parents validation in incremental resolver.

R=brianwilkerson@google.com, skybrian@google.com
BUG= https://github.com/dart-lang/sdk/issues/25514

Committed:
https://github.com/dart-lang/sdk/commit/23e9fbcf3041d2b0a089f128b2841750c3020786
==========

[scheglov, 2016-01-20 16:02:10]

Committed patchset #1 (id:1) manually as
23e9fbcf3041d2b0a089f128b2841750c3020786 (presubmit successful).