Issue 25514. Harden parents validation in incremental resolver.

pkg/analyzer/test/generated/incremental_resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.generated.incremental_resolver_test;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/dart/ast/utilities.dart';
@@ skipping 3785 matching lines @@
 }
 ''');
     _updateAndValidate(r'''
 main() {
   // edited comment text
   print(0);
 }
 ''');
   }
 
-  void test_endOfLineComment_localFunction_inTopLevelVariable() {
-    _resolveUnit(r'''
-typedef int Binary(one, two, three);
-
-int Global = f((a, b, c) {
-  return 0; // Some comment
-});
-''');
-    _updateAndValidate(r'''
-typedef int Binary(one, two, three);
-
-int Global = f((a, b, c) {
-  return 0; // Some  comment
-});
-''');
-  }
-
   void test_endOfLineComment_outBody_add() {
     _resolveUnit(r'''
 main() {
   Object x;
   x.foo();
 }
 ''');
     _updateAndValidate(
         r'''
 // 000
@@ skipping 93 matching lines @@
   const C(this.x);
   const C.foo() : x = 1;
 }
 main() {
   const {const C(0): 0, const C.foo(): 1};
 }
 ''',
         expectedSuccess: false);
   }
 
+  void test_false_constructor_initializer() {

[Brian Wilkerson, 2016/01/20 14:53:56]

Given the number of new cases that appear to have been added, I was expecting
more new tests. Do these really cover all the cases (such as class
declarations)?

+    _resolveUnit(r'''
+class Problem {
+  final Map location;
+  final String message;
+
+  Problem(Map json)
+      : location = json["location"],
+        message = json["message"];
+}''');
+    _updateAndValidate(
+        r'''
+class Problem {
+  final Map location;
+  final String message;
+
+  Problem(Map json)
+      : location = json["location],
+        message = json["message"];
+}''',
+        expectedSuccess: false);
+  }
+
+  void test_false_endOfLineComment_localFunction_inTopLevelVariable() {
+    _resolveUnit(r'''
+typedef int Binary(one, two, three);
+
+int Global = f((a, b, c) {
+  return 0; // Some comment
+});
+''');
+    _updateAndValidate(
+        r'''
+typedef int Binary(one, two, three);
+
+int Global = f((a, b, c) {
+  return 0; // Some  comment
+});
+''',
+        expectedSuccess: false);
+  }
+
   void test_false_expressionBody() {
     _resolveUnit(r'''
 class A {
   final f = (() => 1)();
 }
 ''');
     _updateAndValidate(
         r'''
 class A {
   final f = (() => 2)();
@@ skipping 10 matching lines @@
 ''');
     _updateAndValidate(
         r'''
 class A {
   int m() => 10 * 100;
 }
 ''',
         expectedSuccess: false);
   }
 
+  void test_false_inBody_functionExpression() {
+    _resolveUnit(r'''
+class C extends D {
+  static final f = () {
+    var x = 0;
+  }();
+}
+
+class D {}
+''');
+    _updateAndValidate(
+        r'''
+class C extends D {
+  static final f = () {
+    var x = 01;
+  }();
+}
+
+class D {}
+''',
+        expectedSuccess: false);
+  }
+
   void test_false_topLevelFunction_name() {
     _resolveUnit(r'''
 a() {}
 b() {}
 ''');
     _updateAndValidate(
         r'''
 a() {}
 bb() {}
 ''',
@@ skipping 99 matching lines @@
 ''');
     _updateAndValidate(r'''
 class A {
   m() {
     print(2 + 3);
   }
 }
 ''');
   }
 
-  void test_inBody_functionExpression() {
-    _resolveUnit(r'''
-class C extends D {
-  static final f = () {
-    var x = 0;
-  }();
-}
-
-class D {}
-''');
-    _updateAndValidate(r'''
-class C extends D {
-  static final f = () {
-    var x = 01;
-  }();
-}
-
-class D {}
-''');
-  }
-
   void test_inBody_insertStatement() {
     _resolveUnit(r'''
 main() {
   print(1);
 }
 ''');
     _updateAndValidate(r'''
 main() {
   print(0);
   print(1);
@@ skipping 959 matching lines @@
   @override
   void logException(Object exception, [Object stackTrace]) {
     hasError = true;
   }
 
   @override
   logging.LoggingTimer startTimer() {
     return new logging.LoggingTimer(this);
   }
 }