Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement() calls
showInternal() later.  showInternal() returns false if it failed to show a popup.

Update from crrev.com/370329:
Fix crbug.com/579895.  We check domTreeVersion in updateFromElement(). We
re-create popup only if the DOM tree was modified.

BUG=176241
TEST=manual; See crbug.com/176241.

Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
Cr-Commit-Position: refs/heads/master@{#370329}

Committed: https://crrev.com/c92e23cc419c2db58851f48c12dc55ae73c1a32c
Cr-Commit-Position: refs/heads/master@{#370890}

[tkent, 2016-01-20 01:41:35]

Description was changed from

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

BUG=176241
TEST=manual; See crbug.com/176241.
==========

to

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement()
calls
showInternal() later.  showInternal() returns false if it failed to show a
popup.

BUG=176241
TEST=manual; See crbug.com/176241.
==========

[tkent, 2016-01-20 01:41:50]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2016-01-20 01:41:50]

Keishi, would you review this please?

[keishi, 2016-01-20 03:39:34]

LGTM

https://codereview.chromium.org/1605233002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/ExternalPopupMenu.cpp (right):

https://codereview.chromium.org/1605233002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/ExternalPopupMenu.cpp:164: // We failed to show a
popup.  Notice it to the owner.
nit: s/Notice/Notify/

[tkent, 2016-01-20 04:13:39]

https://codereview.chromium.org/1605233002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/ExternalPopupMenu.cpp (right):

https://codereview.chromium.org/1605233002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/ExternalPopupMenu.cpp:164: // We failed to show a
popup.  Notice it to the owner.
On 2016/01/20 at 03:39:34, keishi wrote:
> nit: s/Notice/Notify/

Done.

[tkent, 2016-01-20 04:13:44]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-01-20 04:13:45]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1605233002/#ps20001
(title: "typo")

[commit-bot: I haz the power, 2016-01-20 04:14:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605233002/20001

[commit-bot: I haz the power, 2016-01-20 06:15:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-20 06:16:09]

Description was changed from

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement()
calls
showInternal() later.  showInternal() returns false if it failed to show a
popup.

BUG=176241
TEST=manual; See crbug.com/176241.
==========

to

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement()
calls
showInternal() later.  showInternal() returns false if it failed to show a
popup.

BUG=176241
TEST=manual; See crbug.com/176241.

Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
Cr-Commit-Position: refs/heads/master@{#370329}
==========

[commit-bot: I haz the power, 2016-01-20 06:16:10]

Patchset 2 (id:??) landed as
https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
Cr-Commit-Position: refs/heads/master@{#370329}

[tkent, 2016-01-21 09:54:20]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1613813002/ by tkent@chromium.org.

The reason for reverting is: caused a regression, crbug.com/579895.

[tkent, 2016-01-22 01:45:44]

Description was changed from

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement()
calls
showInternal() later.  showInternal() returns false if it failed to show a
popup.

BUG=176241
TEST=manual; See crbug.com/176241.

Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
Cr-Commit-Position: refs/heads/master@{#370329}
==========

to

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement()
calls
showInternal() later.  showInternal() returns false if it failed to show a
popup.

Update from crrev.com/370329:
Fix crbug.com/579895.  We check domTreeVersion in updateFromElement(). We
re-create popup only if the DOM tree was modified.

BUG=176241
TEST=manual; See crbug.com/176241.

Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
Cr-Commit-Position: refs/heads/master@{#370329}
==========

[tkent, 2016-01-22 01:47:11]

Reopened, and uploaded new patch.
Keishi, would you review this again please?  The difference is only
ExternalPopupMenu::updateFromElement().

[keishi, 2016-01-22 01:53:05]

LGTM.

Was it recalcStyle that caused the excessive updating?

[tkent, 2016-01-22 01:54:32]

On 2016/01/22 at 01:53:05, keishi wrote:
> Was it recalcStyle that caused the excessive updating?

Yes.  Probably CSS animation.

[tkent, 2016-01-22 02:20:39]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-01-22 02:21:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1605233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1605233002/40001

[commit-bot: I haz the power, 2016-01-22 03:22:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-22 03:23:38]

Description was changed from

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement()
calls
showInternal() later.  showInternal() returns false if it failed to show a
popup.

Update from crrev.com/370329:
Fix crbug.com/579895.  We check domTreeVersion in updateFromElement(). We
re-create popup only if the DOM tree was modified.

BUG=176241
TEST=manual; See crbug.com/176241.

Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
Cr-Commit-Position: refs/heads/master@{#370329}
==========

to

==========
Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

It closes a shown popup, and re-show a popup with the latest content.
This CL affects only OSX and Android.

Implementation:
A major part of show() was moved to showInternal(), and updateFromElement()
calls
showInternal() later.  showInternal() returns false if it failed to show a
popup.

Update from crrev.com/370329:
Fix crbug.com/579895.  We check domTreeVersion in updateFromElement(). We
re-create popup only if the DOM tree was modified.

BUG=176241
TEST=manual; See crbug.com/176241.

Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
Cr-Commit-Position: refs/heads/master@{#370329}

Committed: https://crrev.com/c92e23cc419c2db58851f48c12dc55ae73c1a32c
Cr-Commit-Position: refs/heads/master@{#370890}
==========

[commit-bot: I haz the power, 2016-01-22 03:23:39]

Patchset 3 (id:??) landed as
https://crrev.com/c92e23cc419c2db58851f48c12dc55ae73c1a32c
Cr-Commit-Position: refs/heads/master@{#370890}