third_party/WebKit/Source/web/ExternalPopupMenu.h - Issue 1605233002: Implement PopupMenu::updateFromElement() for ExternalPopupMenu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.h

Issue 1605233002: Implement PopupMenu::updateFromElement() for ExternalPopupMenu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix crbug.com/579895 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ExternalPopupMenu.h

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.h b/third_party/WebKit/Source/web/ExternalPopupMenu.h

index 902d7f33425514d890c2f71c49b4e91c3373fc82..eaa833ec4629166c1001268e9dfa91a33e04cfe7 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.h

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.h

@@ -78,7 +78,9 @@ private:

void didAcceptIndices(const WebVector<int>& indices) override;

void didCancel() override;

+ bool showInternal();

void dispatchEvent(Timer<ExternalPopupMenu>*);

+ void update();

RawPtrWillBeMember<HTMLSelectElement> m_ownerElement;

RefPtrWillBeMember<LocalFrame> m_localFrame;

@@ -87,6 +89,8 @@ private:

Timer<ExternalPopupMenu> m_dispatchEventTimer;

// The actual implementor of the show menu.

WebExternalPopupMenu* m_webExternalPopupMenu;

+ uint64_t m_shownDOMTreeVersion = 0;

+ bool m_needsUpdate = false;

};

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »