Reports Prerender and Profile Total Bytes

chrome/browser/prerender/prerender_histograms.cc

Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index 236c17d4e85e3420b85a2e29dc52d916fef6a88c..e6500d14588df2cee68f179ce226b2bf3d4fae95 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -143,7 +143,8 @@ PrerenderHistograms::PrerenderHistograms()
       last_origin_(ORIGIN_MAX),
       origin_experiment_wash_(false),
       seen_any_pageload_(true),
-      seen_pageload_started_after_prerender_(true) {
+      seen_pageload_started_after_prerender_(true),
+      last_profile_network_bytes_(0) {
 }
 
 void PrerenderHistograms::RecordPrerender(Origin origin, const GURL& url) {
@@ -409,6 +410,22 @@ void PrerenderHistograms::RecordPrerenderPageVisitedStatus(
       UMA_HISTOGRAM_BOOLEAN(name, visited_before));
 }
 
+void PrerenderHistograms::RecordBytes(bool used,
+                                      int64 prerender_bytes,
+                                      int64 profile_bytes) {
+  if (used)
+    UMA_HISTOGRAM_COUNTS("Prerender.NetworkBytes.Used.KB",

[tburkard, 2014/02/12 19:54:56]

nit: shouldnt { } be used if it's more than one line?

[jkarlin, 2014/02/13 13:24:49]

Done.

+                         prerender_bytes >> 10);
+  else
+    UMA_HISTOGRAM_COUNTS("Prerender.NetworkBytes.Wasted.KB",
+                         prerender_bytes >> 10);
+
+  int64 recent_profile_bytes = profile_bytes - last_profile_network_bytes_;

[tburkard, 2014/02/12 19:54:56]

I would keep PrerenderHistograms dead simple, and literally just emit the
histogram.

I'd put this logic into prerender_manager, similar to the way you put it into
prerender_contents in the other case.

[jkarlin, 2014/02/13 13:24:49]

Done.

+  last_profile_network_bytes_ = profile_bytes;
+  UMA_HISTOGRAM_COUNTS("Prerender.NetworkBytes.TotalForProfile.KB",
+                       recent_profile_bytes >> 10);
+}
+
 uint8 PrerenderHistograms::GetCurrentExperimentId() const {
   if (!WithinWindow())
     return kNoExperiment;