Reports Prerender and Profile Total Bytes

chrome/browser/prerender/prerender_histograms.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prerender/prerender_histograms.h"
 
 #include <string>
 
 #include "base/format_macros.h"
 #include "base/metrics/histogram.h"
@@ skipping 125 matching lines @@
   } else { \
     HISTOGRAM; \
   } \
 } while (0)
 
 PrerenderHistograms::PrerenderHistograms()
     : last_experiment_id_(kNoExperiment),
       last_origin_(ORIGIN_MAX),
       origin_experiment_wash_(false),
       seen_any_pageload_(true),
-      seen_pageload_started_after_prerender_(true) {
+      seen_pageload_started_after_prerender_(true),
+      last_profile_network_bytes_(0) {
 }
 
 void PrerenderHistograms::RecordPrerender(Origin origin, const GURL& url) {
   // Check if we are doing an experiment.
   uint8 experiment = GetQueryStringBasedExperiment(url);
 
   // We need to update last_experiment_id_, last_origin_, and
   // origin_experiment_wash_.
   if (!WithinWindow()) {
     // If we are outside a window, this is a fresh start and we are fine,
@@ skipping 245 matching lines @@
 
 void PrerenderHistograms::RecordPrerenderPageVisitedStatus(
     Origin origin,
     uint8 experiment_id,
     bool visited_before) const {
   PREFIXED_HISTOGRAM_ORIGIN_EXPERIMENT(
       "PageVisitedStatus", origin, experiment_id,
       UMA_HISTOGRAM_BOOLEAN(name, visited_before));
 }
 
+void PrerenderHistograms::RecordBytes(bool used,
+                                      int64 prerender_bytes,
+                                      int64 profile_bytes) {
+  if (used)
+    UMA_HISTOGRAM_COUNTS("Prerender.NetworkBytes.Used.KB",

[tburkard, 2014/02/12 19:54:56]

nit: shouldnt { } be used if it's more than one line?

[jkarlin, 2014/02/13 13:24:49]

Done.

+                         prerender_bytes >> 10);
+  else
+    UMA_HISTOGRAM_COUNTS("Prerender.NetworkBytes.Wasted.KB",
+                         prerender_bytes >> 10);
+
+  int64 recent_profile_bytes = profile_bytes - last_profile_network_bytes_;

[tburkard, 2014/02/12 19:54:56]

I would keep PrerenderHistograms dead simple, and literally just emit the
histogram.

I'd put this logic into prerender_manager, similar to the way you put it into
prerender_contents in the other case.

[jkarlin, 2014/02/13 13:24:49]

Done.

+  last_profile_network_bytes_ = profile_bytes;
+  UMA_HISTOGRAM_COUNTS("Prerender.NetworkBytes.TotalForProfile.KB",
+                       recent_profile_bytes >> 10);
+}
+
 uint8 PrerenderHistograms::GetCurrentExperimentId() const {
   if (!WithinWindow())
     return kNoExperiment;
   return last_experiment_id_;
 }
 
 bool PrerenderHistograms::IsOriginExperimentWash() const {
   if (!WithinWindow())
     return false;
   return origin_experiment_wash_;
 }
 
 }  // namespace prerender