gtk: Move the enter/leave-notify-event handling to TabRendererGtk and hook up...

gtk: Move the enter/leave-notify-event handling to TabRendererGtk and hook up the close button signals to this handler.

BUG=18196
TEST=Open two tabs.  Hover the mouse over the close button of the inactive tab.  The inactive tab should stay highlighted.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22297

[Elliot Glaysher, 2009-08-03 03:30:29]

LGTM + Nit

http://codereview.chromium.org/160512/diff/1/4
File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/160512/diff/1/4#newcode867
Line 867: GdkEventCrossing* event,
Spacing?

[James Hawkins, 2009-08-03 03:40:16]

http://codereview.chromium.org/160512/diff/1/4
File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/160512/diff/1/4#newcode867
Line 867: GdkEventCrossing* event,
On 2009/08/03 03:30:29, Elliot Glaysher wrote:
> Spacing?

I'm not sure what you're pointing out.  Little help?

[Elliot Glaysher, 2009-08-03 03:41:46]

http://codereview.chromium.org/160512/diff/1/4
File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/160512/diff/1/4#newcode867
Line 867: GdkEventCrossing* event,
On 2009/08/03 03:40:16, James Hawkins wrote:
> On 2009/08/03 03:30:29, Elliot Glaysher wrote:
> > Spacing?
> 
> I'm not sure what you're pointing out.  Little help?

"GdkEventCrossing* event," and "TabRenderGtk* tab) {" should have one additional
space; they aren't lined up with the '(' character. Same with
OnLeaveNotifyEvent.

[James Hawkins, 2009-08-03 03:45:02]

http://codereview.chromium.org/160512/diff/1/4
File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/160512/diff/1/4#newcode867
Line 867: GdkEventCrossing* event,
On 2009/08/03 03:41:46, Elliot Glaysher wrote:
> On 2009/08/03 03:40:16, James Hawkins wrote:
> > On 2009/08/03 03:30:29, Elliot Glaysher wrote:
> > > Spacing?
> > 
> > I'm not sure what you're pointing out.  Little help?
> 
> "GdkEventCrossing* event," and "TabRenderGtk* tab) {" should have one
additional
> space; they aren't lined up with the '(' character. Same with
> OnLeaveNotifyEvent.

In my editor and this CL, The G's in GtkWidget and GdkEventCrossing line up
(same for the T of TabRendererGtk).  We're seeing something different?

[James Hawkins, 2009-08-03 18:27:29]

On 2009/08/03 03:45:02, James Hawkins wrote:
> http://codereview.chromium.org/160512/diff/1/4
> File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):
> 
> http://codereview.chromium.org/160512/diff/1/4#newcode867
> Line 867: GdkEventCrossing* event,
> On 2009/08/03 03:41:46, Elliot Glaysher wrote:
> > On 2009/08/03 03:40:16, James Hawkins wrote:
> > > On 2009/08/03 03:30:29, Elliot Glaysher wrote:
> > > > Spacing?
> > > 
> > > I'm not sure what you're pointing out.  Little help?
> > 
> > "GdkEventCrossing* event," and "TabRenderGtk* tab) {" should have one
> additional
> > space; they aren't lined up with the '(' character. Same with
> > OnLeaveNotifyEvent.
> 
> In my editor and this CL, The G's in GtkWidget and GdkEventCrossing line up
> (same for the T of TabRendererGtk).  We're seeing something different?

ping

[Elliot Glaysher, 2009-08-03 18:39:40]

(wrote this last night but didn't hit publish.)

http://codereview.chromium.org/160512/diff/1/4
File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right):

http://codereview.chromium.org/160512/diff/1/4#newcode867
Line 867: GdkEventCrossing* event,
On 2009/08/03 03:45:02, James Hawkins wrote:
> On 2009/08/03 03:41:46, Elliot Glaysher wrote:
> > On 2009/08/03 03:40:16, James Hawkins wrote:
> > > On 2009/08/03 03:30:29, Elliot Glaysher wrote:
> > > > Spacing?
> > > 
> > > I'm not sure what you're pointing out.  Little help?
> > 
> > "GdkEventCrossing* event," and "TabRenderGtk* tab) {" should have one
> additional
> > space; they aren't lined up with the '(' character. Same with
> > OnLeaveNotifyEvent.
> 
> In my editor and this CL, The G's in GtkWidget and GdkEventCrossing line up
> (same for the T of TabRendererGtk).  We're seeing something different?

Build of Chromium Linux from Friday: Off by one space

Windows Chromium; Linux Firefox: Spacing looks OK.

Really weird. LGTM.