gtk: Move the enter/leave-notify-event handling to TabRendererGtk and hook up...

chrome/browser/gtk/tabs/tab_renderer_gtk.cc

Index: chrome/browser/gtk/tabs/tab_renderer_gtk.cc
===================================================================
--- chrome/browser/gtk/tabs/tab_renderer_gtk.cc	(revision 22256)
+++ chrome/browser/gtk/tabs/tab_renderer_gtk.cc	(working copy)
@@ -805,6 +805,10 @@
                    G_CALLBACK(OnCloseButtonClicked), this);
   g_signal_connect(G_OBJECT(button->widget()), "button-release-event",
                    G_CALLBACK(OnCloseButtonMouseRelease), this);
+  g_signal_connect(G_OBJECT(button->widget()), "enter-notify-event",
+                   G_CALLBACK(OnEnterNotifyEvent), this);
+  g_signal_connect(G_OBJECT(button->widget()), "leave-notify-event",
+                   G_CALLBACK(OnLeaveNotifyEvent), this);
   GTK_WIDGET_UNSET_FLAGS(button->widget(), GTK_CAN_FOCUS);
   gtk_fixed_put(GTK_FIXED(tab_.get()), button->widget(), 0, 0);
 
@@ -858,14 +862,22 @@
   tab->Layout();
 }
 
-void TabRendererGtk::OnMouseEntered() {
-  hover_animation_->SetTweenType(SlideAnimation::EASE_OUT);
-  hover_animation_->Show();
+// static
+gboolean TabRendererGtk::OnEnterNotifyEvent(GtkWidget* widget,
+                                            GdkEventCrossing* event,

[Elliot Glaysher, 2009/08/03 03:30:29]

Spacing?

[James Hawkins, 2009/08/03 03:40:16]

I'm not sure what you're pointing out.  Little help?

[Elliot Glaysher, 2009/08/03 03:41:46]

"GdkEventCrossing* event," and "TabRenderGtk* tab) {" should have one additional
space; they aren't lined up with the '(' character. Same with
OnLeaveNotifyEvent.

[James Hawkins, 2009/08/03 03:45:02]

In my editor and this CL, The G's in GtkWidget and GdkEventCrossing line up
(same for the T of TabRendererGtk).  We're seeing something different?

[Elliot Glaysher, 2009/08/03 18:39:40]

Build of Chromium Linux from Friday: Off by one space

Windows Chromium; Linux Firefox: Spacing looks OK.

Really weird. LGTM.

+                                            TabRendererGtk* tab) {
+  tab->hover_animation_->SetTweenType(SlideAnimation::EASE_OUT);
+  tab->hover_animation_->Show();
+  return FALSE;
 }
 
-void TabRendererGtk::OnMouseExited() {
-  hover_animation_->SetTweenType(SlideAnimation::EASE_IN);
-  hover_animation_->Hide();
+// static
+gboolean TabRendererGtk::OnLeaveNotifyEvent(GtkWidget* widget,
+                                            GdkEventCrossing* event,
+                                            TabRendererGtk* tab) {
+  tab->hover_animation_->SetTweenType(SlideAnimation::EASE_IN);
+  tab->hover_animation_->Hide();
+  return FALSE;
 }
 
 // static