Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1604913002: [Crankshaft] ia32/x64: Fix environment handling for LMulI (Closed)

Created:
4 years, 11 months ago by Jakob Kummerow
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Crankshaft] ia32/x64: Fix environment handling for LMulI This is the ia32/x64 version of https://codereview.chromium.org/873703002, which fixed the same problem on arm/arm64. BUG=chromium:553441 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/2dde677feb0b756eff077ca29744024242834c56 Cr-Commit-Position: refs/heads/master@{#33386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL. Unfortunately I can't check in the regression test because when it doesn't crash (after ...
4 years, 11 months ago (2016-01-19 13:37:06 UTC) #1
Yang
On 2016/01/19 13:37:06, Jakob wrote: > PTAL. > > Unfortunately I can't check in the ...
4 years, 11 months ago (2016-01-19 14:16:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604913002/1
4 years, 11 months ago (2016-01-19 14:18:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 14:40:01 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 14:41:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dde677feb0b756eff077ca29744024242834c56
Cr-Commit-Position: refs/heads/master@{#33386}

Powered by Google App Engine
This is Rietveld 408576698