Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 1604693002: Remove unused function after https://codereview.chromium.org/1586843002 (Closed)

Created:
4 years, 11 months ago by scottmg
Modified:
4 years, 11 months ago
Reviewers:
Nico, ananta
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused function after https://codereview.chromium.org/1586843002 Found by clang: ..\..\win8\delegate_execute\command_execute_impl.cc(69,6) : error: unused function 'LaunchChromeBrowserProcess' [-Werror,-Wunused-function] R=thakis@chromium.org TBR=ananta@chromium.org BUG=558054, 82385 Committed: https://crrev.com/459c246b5b9e02eb98310e729bdfaada5f7b4521 Cr-Commit-Position: refs/heads/master@{#370074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M win8/delegate_execute/command_execute_impl.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
scottmg
4 years, 11 months ago (2016-01-19 03:08:25 UTC) #1
Nico
lgtm
4 years, 11 months ago (2016-01-19 03:12:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604693002/1
4 years, 11 months ago (2016-01-19 03:13:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 04:16:02 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 04:17:35 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/459c246b5b9e02eb98310e729bdfaada5f7b4521
Cr-Commit-Position: refs/heads/master@{#370074}

Powered by Google App Engine
This is Rietveld 408576698