Reset algorithm is incorrect for select element with first option disabled

Reset algorithm is incorrect for select element with first option disabled

As per the spec (https://www.w3.org/TR/html5/forms.html#ask-for-a-reset),
the user agent must set the selectedness of the first option element in the list
of options in tree order that is not disabled, if any, to true.

BUG=578705
Committed: https://crrev.com/5b2038755e5c1e046642373d6b3add2452b8eb2e
Cr-Commit-Position: refs/heads/master@{#370303}

[nolan.robin.cao, 2016-01-19 19:15:12]

Description was changed from

==========
Reset algorithm is incorrect for select element with first option disabled

As per the spec (https://www.w3.org/TR/html5/forms.html#ask-for-a-reset),
the user agent must set the selectedness of the first option element in the list
of options in tree order that is not disabled, if any, to true.

BUG=578705
==========

to

==========
Reset algorithm is incorrect for select element with first option disabled

As per the spec (https://www.w3.org/TR/html5/forms.html#ask-for-a-reset),
the user agent must set the selectedness of the first option element in the list
of options in tree order that is not disabled, if any, to true.

BUG=578705
==========

[nolan.robin.cao, 2016-01-19 19:15:12]

nolan.robin.cao@gmail.com changed reviewers:
+ tkent@chromium.org

[nolan.robin.cao, 2016-01-19 19:18:54]

Please take a look, thanks.

[tkent, 2016-01-19 23:54:31]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 23:56:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604653005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604653005/1

[commit-bot: I haz the power, 2016-01-20 02:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 02:09:19]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-01-20 02:42:31]

lgtm.

Ideally we should merge the default selection implementations in resetImpl() and
recalcListItems().

[tkent, 2016-01-20 02:42:40]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-01-20 02:42:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604653005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604653005/1

[nolan.robin.cao, 2016-01-20 03:20:50]

On 2016/01/20 02:42:31, tkent wrote:
> lgtm.
> 
> Ideally we should merge the default selection implementations in resetImpl()
and
> recalcListItems().

Thank you very much, tkent!

I will see if the the default selection implementations can be merged in a
followup patch.

[commit-bot: I haz the power, 2016-01-20 05:07:45]

Description was changed from

==========
Reset algorithm is incorrect for select element with first option disabled

As per the spec (https://www.w3.org/TR/html5/forms.html#ask-for-a-reset),
the user agent must set the selectedness of the first option element in the list
of options in tree order that is not disabled, if any, to true.

BUG=578705
==========

to

==========
Reset algorithm is incorrect for select element with first option disabled

As per the spec (https://www.w3.org/TR/html5/forms.html#ask-for-a-reset),
the user agent must set the selectedness of the first option element in the list
of options in tree order that is not disabled, if any, to true.

BUG=578705
==========

[commit-bot: I haz the power, 2016-01-20 05:07:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-20 05:08:51]

Description was changed from

==========
Reset algorithm is incorrect for select element with first option disabled

As per the spec (https://www.w3.org/TR/html5/forms.html#ask-for-a-reset),
the user agent must set the selectedness of the first option element in the list
of options in tree order that is not disabled, if any, to true.

BUG=578705
==========

to

==========
Reset algorithm is incorrect for select element with first option disabled

As per the spec (https://www.w3.org/TR/html5/forms.html#ask-for-a-reset),
the user agent must set the selectedness of the first option element in the list
of options in tree order that is not disabled, if any, to true.

BUG=578705

Committed: https://crrev.com/5b2038755e5c1e046642373d6b3add2452b8eb2e
Cr-Commit-Position: refs/heads/master@{#370303}
==========

[commit-bot: I haz the power, 2016-01-20 05:08:52]

Patchset 1 (id:??) landed as
https://crrev.com/5b2038755e5c1e046642373d6b3add2452b8eb2e
Cr-Commit-Position: refs/heads/master@{#370303}