third_party/WebKit/Source/core/html/HTMLSelectElement.cpp - Issue 1604653005: Reset algorithm is incorrect for select element with first option disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 1604653005: Reset algorithm is incorrect for select element with first option disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

index ad4c1d65e14891a663eb1110f58b3a3e37fa2def..715dd8552d7946f17dc1bfc36f734ae3e1e38d60 100644

--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

@@ -1250,7 +1250,7 @@ void HTMLSelectElement::resetImpl()

}

option->setDirty(false);

- if (!firstOption)

+ if (!firstOption && !option->isDisabledFormControl())

firstOption = option;

}

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select/select-ask-for-reset.html ('k') | no next file » | no next file with comments »