Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 16045007: Revert 202427 "Translate: adopt html lang attribute if valid val..." (Closed)

Created:
7 years, 7 months ago by Takashi Toyoshima
Modified:
7 years, 7 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202427 "Translate: adopt html lang attribute if valid val..." > Translate: adopt html lang attribute if valid value is provided > > Language decision is made by heuristics using Content-Language and CLD > determined language. This change adds html lang attribute, e.g., > <html lang="ja">, as a third hint for language decision. > Content-Language is often invalid due to invalid server configuration. > On the other hand, lang attribute is provided by pages, or authoring > tools or authors themselves. As a result, they are more reliable than > Content-Language. With this change, language decision uses html lang > attribute instead of Content-Language if valid value is provided. > Other dicision process is not changed at all. > > BUG=222073 > TEST=unit_tests, browser_tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201856 > > Review URL: https://chromiumcodereview.appspot.com/15728002 TBR=toyoshim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -162 lines) Patch
M trunk/src/chrome/renderer/translate/translate_helper.h View 1 chunk +4 lines, -9 lines 0 comments Download
M trunk/src/chrome/renderer/translate/translate_helper.cc View 6 chunks +19 lines, -47 lines 0 comments Download
M trunk/src/chrome/renderer/translate/translate_helper_metrics.h View 3 chunks +6 lines, -14 lines 0 comments Download
M trunk/src/chrome/renderer/translate/translate_helper_metrics.cc View 3 chunks +13 lines, -23 lines 0 comments Download
M trunk/src/chrome/renderer/translate/translate_helper_metrics_unittest.cc View 2 chunks +18 lines, -28 lines 0 comments Download
M trunk/src/chrome/renderer/translate/translate_helper_unittest.cc View 3 chunks +4 lines, -27 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Takashi Toyoshima
7 years, 7 months ago (2013-05-27 16:33:52 UTC) #1
Takashi Toyoshima
7 years, 7 months ago (2013-05-27 16:34:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r202443.

Powered by Google App Engine
This is Rietveld 408576698