Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: trunk/src/chrome/renderer/translate/translate_helper_metrics.cc

Issue 16045007: Revert 202427 "Translate: adopt html lang attribute if valid val..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/translate/translate_helper_metrics.h" 5 #include "chrome/renderer/translate/translate_helper_metrics.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 9
10 namespace { 10 namespace {
11 11
12 // Constant string values to indicate UMA names. All entries should have 12 // Constant string values to indicate UMA names. All entries should have
13 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|. 13 // a corresponding index in MetricsNameIndex and an entry in |kMetricsEntries|.
14 const char kRenderer4LanguageDetection[] = "Renderer4.LanguageDetection"; 14 const char kRenderer4LanguageDetection[] = "Renderer4.LanguageDetection";
15 const char kTranslateContentLanguage[] = "Translate.ContentLanguage"; 15 const char kTranslateContentLanguage[] = "Translate.ContentLanguage";
16 const char kTranslateHtmlLang[] = "Translate.HtmlLang";
17 const char kTranslateLanguageVerification[] = "Translate.LanguageVerification"; 16 const char kTranslateLanguageVerification[] = "Translate.LanguageVerification";
18 const char kTranslateTimeToBeReady[] = "Translate.TimeToBeReady"; 17 const char kTranslateTimeToBeReady[] = "Translate.TimeToBeReady";
19 const char kTranslateTimeToLoad[] = "Translate.TimeToLoad"; 18 const char kTranslateTimeToLoad[] = "Translate.TimeToLoad";
20 const char kTranslateTimeToTranslate[] = "Translate.TimeToTranslate"; 19 const char kTranslateTimeToTranslate[] = "Translate.TimeToTranslate";
21 const char kTranslateUserActionDuration[] = "Translate.UserActionDuration"; 20 const char kTranslateUserActionDuration[] = "Translate.UserActionDuration";
22 const char kTranslatePageScheme[] = "Translate.PageScheme"; 21 const char kTranslatePageScheme[] = "Translate.PageScheme";
23 22
24 const char kSchemeHttp[] = "http"; 23 const char kSchemeHttp[] = "http";
25 const char kSchemeHttps[] = "https"; 24 const char kSchemeHttps[] = "https";
26 25
27 struct MetricsEntry { 26 struct MetricsEntry {
28 TranslateHelperMetrics::MetricsNameIndex index; 27 TranslateHelperMetrics::MetricsNameIndex index;
29 const char* const name; 28 const char* const name;
30 }; 29 };
31 30
32 // This entry table should be updated when new UMA items are added. 31 // This entry table should be updated when new UMA items are added.
33 const MetricsEntry kMetricsEntries[] = { 32 const MetricsEntry kMetricsEntries[] = {
34 { TranslateHelperMetrics::UMA_LANGUAGE_DETECTION, 33 { TranslateHelperMetrics::UMA_LANGUAGE_DETECTION,
35 kRenderer4LanguageDetection }, 34 kRenderer4LanguageDetection },
36 { TranslateHelperMetrics::UMA_CONTENT_LANGUAGE, 35 { TranslateHelperMetrics::UMA_CONTENT_LANGUAGE,
37 kTranslateContentLanguage }, 36 kTranslateContentLanguage },
38 { TranslateHelperMetrics::UMA_HTML_LANG,
39 kTranslateHtmlLang },
40 { TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION, 37 { TranslateHelperMetrics::UMA_LANGUAGE_VERIFICATION,
41 kTranslateLanguageVerification }, 38 kTranslateLanguageVerification },
42 { TranslateHelperMetrics::UMA_TIME_TO_BE_READY, 39 { TranslateHelperMetrics::UMA_TIME_TO_BE_READY,
43 kTranslateTimeToBeReady }, 40 kTranslateTimeToBeReady },
44 { TranslateHelperMetrics::UMA_TIME_TO_LOAD, 41 { TranslateHelperMetrics::UMA_TIME_TO_LOAD,
45 kTranslateTimeToLoad }, 42 kTranslateTimeToLoad },
46 { TranslateHelperMetrics::UMA_TIME_TO_TRANSLATE, 43 { TranslateHelperMetrics::UMA_TIME_TO_TRANSLATE,
47 kTranslateTimeToTranslate }, 44 kTranslateTimeToTranslate },
48 { TranslateHelperMetrics::UMA_USER_ACTION_DURATION, 45 { TranslateHelperMetrics::UMA_USER_ACTION_DURATION,
49 kTranslateUserActionDuration }, 46 kTranslateUserActionDuration },
50 { TranslateHelperMetrics::UMA_PAGE_SCHEME, 47 { TranslateHelperMetrics::UMA_PAGE_SCHEME,
51 kTranslatePageScheme }, 48 kTranslatePageScheme },
52 }; 49 };
53 50
54 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateHelperMetrics::UMA_MAX, 51 COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateHelperMetrics::UMA_MAX,
55 arraysize_of_kMetricsEntries_should_be_UMA_MAX); 52 arraysize_of_kMetricsEntries_should_be_UMA_MAX);
56 53
57 TranslateHelperMetrics::LanguageCheckType GetLanguageCheckMetric(
58 const std::string& provided_code,
59 const std::string& revised_code) {
60 if (provided_code.empty())
61 return TranslateHelperMetrics::LANGUAGE_NOT_PROVIDED;
62 else if (provided_code == revised_code)
63 return TranslateHelperMetrics::LANGUAGE_VALID;
64 return TranslateHelperMetrics::LANGUAGE_INVALID;
65 }
66
67 } // namespace 54 } // namespace
68 55
69 namespace TranslateHelperMetrics { 56 namespace TranslateHelperMetrics {
70 57
71 void ReportContentLanguage(const std::string& provided_code, 58 void ReportContentLanguage(const std::string& provided_code,
72 const std::string& revised_code) { 59 const std::string& revised_code) {
73 UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage, 60 if (provided_code.empty()) {
74 GetLanguageCheckMetric(provided_code, revised_code), 61 UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage,
75 TranslateHelperMetrics::LANGUAGE_MAX); 62 CONTENT_LANGUAGE_NOT_PROVIDED,
76 } 63 CONTENT_LANGUAGE_MAX);
77 64 } else if (provided_code == revised_code) {
78 void ReportHtmlLang(const std::string& provided_code, 65 UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage,
79 const std::string& revised_code) { 66 CONTENT_LANGUAGE_VALID,
80 UMA_HISTOGRAM_ENUMERATION(kTranslateHtmlLang, 67 CONTENT_LANGUAGE_MAX);
81 GetLanguageCheckMetric(provided_code, revised_code), 68 } else {
82 TranslateHelperMetrics::LANGUAGE_MAX); 69 UMA_HISTOGRAM_ENUMERATION(kTranslateContentLanguage,
70 CONTENT_LANGUAGE_INVALID,
71 CONTENT_LANGUAGE_MAX);
72 }
83 } 73 }
84 74
85 void ReportLanguageVerification(LanguageVerificationType type) { 75 void ReportLanguageVerification(LanguageVerificationType type) {
86 UMA_HISTOGRAM_ENUMERATION(kTranslateLanguageVerification, 76 UMA_HISTOGRAM_ENUMERATION(kTranslateLanguageVerification,
87 type, 77 type,
88 LANGUAGE_VERIFICATION_MAX); 78 LANGUAGE_VERIFICATION_MAX);
89 } 79 }
90 80
91 void ReportTimeToBeReady(double time_in_msec) { 81 void ReportTimeToBeReady(double time_in_msec) {
92 UMA_HISTOGRAM_MEDIUM_TIMES( 82 UMA_HISTOGRAM_MEDIUM_TIMES(
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 const char* GetMetricsName(MetricsNameIndex index) { 120 const char* GetMetricsName(MetricsNameIndex index) {
131 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) { 121 for (size_t i = 0; i < arraysize(kMetricsEntries); ++i) {
132 if (kMetricsEntries[i].index == index) 122 if (kMetricsEntries[i].index == index)
133 return kMetricsEntries[i].name; 123 return kMetricsEntries[i].name;
134 } 124 }
135 NOTREACHED(); 125 NOTREACHED();
136 return NULL; 126 return NULL;
137 } 127 }
138 128
139 } // namespace TranslateHelperMetrics 129 } // namespace TranslateHelperMetrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698