Let SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

Let SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

We use depot_tools's toolchain to build LLVM on the clang/win bots.
llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK,
so set it.  While here, also set VCINSTALLDIR.

BUG=82385
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298326

[Nico, 2016-01-20 20:46:25]

thakis@chromium.org changed reviewers:
+ scottmg@chromium.org

[Nico, 2016-01-20 20:46:25]

If this goes in, how long does it take to make it into the deployed toolchain?

[scottmg, 2016-01-20 20:50:24]

scottmg@chromium.org changed reviewers:
+ brucedawson@chromium.org

[scottmg, 2016-01-20 20:50:24]

lgtm

If you can convince Bruce to repackage 2015, this could be in the 2015 rollout
which should be "real soon".

https://codereview.chromium.org/1604423002/diff/1/win_toolchain/package_from_...
File win_toolchain/package_from_installed.py (right):

https://codereview.chromium.org/1604423002/diff/1/win_toolchain/package_from_...
win_toolchain/package_from_installed.py:187: 'set
VCINSTALLDIR=%~dp0..\\..\\VC\\\n'
Yuck, these do have trailing \ in vcvarsall. :(

[Nico, 2016-01-20 20:51:07]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-01-20 20:51:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604423002/1

[Nico, 2016-01-20 20:52:24]

On 2016/01/20 20:50:24, scottmg wrote:
> lgtm
> 
> If you can convince Bruce to repackage 2015, this could be in the 2015 rollout
> which should be "real soon".

That should be no problem, I took a rhetoric class recently! Watch this:

bruuuuuuuuuuuuuce
pleeeeeeaaaaaaase

pleeeeeeeeeeaaaaaaaaaaaase

[commit-bot: I haz the power, 2016-01-20 20:53:01]

Description was changed from

==========
Set SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

We use depot_tools's toolchain to build LLVM on the clang/win bots.
llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK,
so set it.  While here, also set VCINSTALLDIR.

BUG=82385
==========

to

==========
Set SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

We use depot_tools's toolchain to build LLVM on the clang/win bots.
llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK,
so set it.  While here, also set VCINSTALLDIR.

BUG=82385

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298326
==========

[commit-bot: I haz the power, 2016-01-20 20:53:02]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298326

[Nico, 2016-01-20 20:54:23]

Description was changed from

==========
Set SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

We use depot_tools's toolchain to build LLVM on the clang/win bots.
llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK,
so set it.  While here, also set VCINSTALLDIR.

BUG=82385

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298326
==========

to

==========
Let SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

We use depot_tools's toolchain to build LLVM on the clang/win bots.
llvm-symbolizer relies on VSINSTALLDIR to be set to find the DIA SDK,
so set it.  While here, also set VCINSTALLDIR.

BUG=82385

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298326
==========

[brucedawson, 2016-01-20 20:58:30]

On 2016/01/20 20:52:24, Nico wrote:
> On 2016/01/20 20:50:24, scottmg wrote:
> > lgtm
> > 
> > If you can convince Bruce to repackage 2015, this could be in the 2015
rollout
> > which should be "real soon".
> 
> That should be no problem, I took a rhetoric class recently! Watch this:
> 
> bruuuuuuuuuuuuuce
> pleeeeeeaaaaaaase
> 
> pleeeeeeeeeeaaaaaaaaaaaase

You will remove these restraints and leave this cell with the door open.

Yeah, I should be able to do that. I've got the VMs setup for packaging VS.