win_toolchain/package_from_installed.py - Issue 1604423002: Let SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win_toolchain/package_from_installed.py

Issue 1604423002: Let SetEnv.cmd set VSINSTALLDIR, VCINSTALLDIR (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win_toolchain/package_from_installed.py

diff --git a/win_toolchain/package_from_installed.py b/win_toolchain/package_from_installed.py

index e0a3ff262e33506da6d25bfa7e93aab745e17425..a178864a1633a15cb17fad9f9b379f72ca4d73ca 100644

--- a/win_toolchain/package_from_installed.py

+++ b/win_toolchain/package_from_installed.py

@@ -183,6 +183,8 @@ def GenerateSetEnvCmd(target_dir):

f.write('@echo off\n'

':: Generated by win_toolchain\\package_from_installed.py.\n'

# Common to x86 and x64

+ 'set VSINSTALLDIR=%~dp0..\\..\\\n'

+ 'set VCINSTALLDIR=%~dp0..\\..\\VC\\\n'

scottmg 2016/01/20 20:50:24 Yuck, these do have trailing \ in vcvarsall. :(

'set PATH=%~dp0..\\..\\Common7\\IDE;%PATH%\n'

'set INCLUDE=%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\um;'

'%~dp0..\\..\\win_sdk\\Include\\WINVERSION\\shared;'

« no previous file with comments | « no previous file | no next file » | no next file with comments »