Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1604333002: Implement TypeMask.isDisjoint instead of using intersection. (Closed)

Created:
4 years, 11 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 11 months ago
Reviewers:
asgerf, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement TypeMask.isDisjoint instead of using intersection. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/e17d3d39ab19406631e68efaacc6fd703eff188e

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -16 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 chunk +47 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/type_mask_disjoint_test.dart View 1 1 chunk +184 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Siggi Cherem (dart-lang)
4 years, 11 months ago (2016-01-20 21:36:35 UTC) #4
sra1
lgtm https://codereview.chromium.org/1604333002/diff/40001/tests/compiler/dart2js/type_mask_disjoint_test.dart File tests/compiler/dart2js/type_mask_disjoint_test.dart (right): https://codereview.chromium.org/1604333002/diff/40001/tests/compiler/dart2js/type_mask_disjoint_test.dart#newcode25 tests/compiler/dart2js/type_mask_disjoint_test.dart:25: Test mixins too (another kind of 'implements')
4 years, 11 months ago (2016-01-20 21:53:48 UTC) #5
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1604333002/diff/40001/tests/compiler/dart2js/type_mask_disjoint_test.dart File tests/compiler/dart2js/type_mask_disjoint_test.dart (right): https://codereview.chromium.org/1604333002/diff/40001/tests/compiler/dart2js/type_mask_disjoint_test.dart#newcode25 tests/compiler/dart2js/type_mask_disjoint_test.dart:25: On 2016/01/20 21:53:48, sra1 wrote: > Test mixins too ...
4 years, 11 months ago (2016-01-20 22:14:57 UTC) #6
Siggi Cherem (dart-lang)
4 years, 11 months ago (2016-01-20 22:18:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:60001) manually as
e17d3d39ab19406631e68efaacc6fd703eff188e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698