Remember/restore the bookmark manager pane position.

Remember/restore the bookmark manager pane position.

BUG=18071
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22113

[Elliot Glaysher, 2009-07-30 22:08:50]

LGTM

On Thu, Jul 30, 2009 at 2:57 PM, <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Remember/restore the bookmark manager pane position.
>
> BUG=3D18071
>
>
> Please review this at http://codereview.chromium.org/160422
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/gtk/bookmark_manager_gtk.h
> =A0M =A0 =A0 chrome/browser/gtk/bookmark_manager_gtk.cc
>
>
> Index: chrome/browser/gtk/bookmark_manager_gtk.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/gtk/bookmark_manager_gtk.cc =A0(revision 22090)
> +++ chrome/browser/gtk/bookmark_manager_gtk.cc =A0(working copy)
> @@ -331,6 +331,9 @@
> =A0}
>
> =A0BookmarkManagerGtk::~BookmarkManagerGtk() {
> + =A0g_browser_process->local_state()->SetInteger(
> + =A0 =A0 =A0prefs::kBookmarkManagerSplitLocation,
> + =A0 =A0 =A0gtk_paned_get_position(GTK_PANED(paned_)));
> =A0 SaveColumnConfiguration();
> =A0 model_->RemoveObserver(this);
> =A0}
> @@ -403,15 +406,26 @@
> =A0 GtkWidget* left_pane =3D MakeLeftPane();
> =A0 GtkWidget* right_pane =3D MakeRightPane();
>
> - =A0GtkWidget* paned =3D gtk_hpaned_new();
> + =A0paned_ =3D gtk_hpaned_new();
> + =A0gtk_paned_pack1(GTK_PANED(paned_), left_pane, FALSE, FALSE);
> + =A0gtk_paned_pack2(GTK_PANED(paned_), right_pane, TRUE, FALSE);
> +
> =A0 // Set the initial position of the pane divider.
> - =A0gtk_paned_set_position(GTK_PANED(paned), width / 3);
> - =A0gtk_paned_pack1(GTK_PANED(paned), left_pane, FALSE, FALSE);
> - =A0gtk_paned_pack2(GTK_PANED(paned), right_pane, TRUE, FALSE);
> + =A0int split_x =3D g_browser_process->local_state()->GetInteger(
> + =A0 =A0 =A0prefs::kBookmarkManagerSplitLocation);
> + =A0if (split_x =3D=3D -1) {
> + =A0 =A0split_x =3D width / 3;
> + =A0} else {
> + =A0 =A0int min_split_size =3D width / 8;
> + =A0 =A0// Make sure the user can see both the tree/table.
> + =A0 =A0split_x =3D std::min(width - min_split_size,
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 std::max(min_split_size, sp=
lit_x));
> + =A0}
> + =A0gtk_paned_set_position(GTK_PANED(paned_), split_x);
>
> =A0 GtkWidget* vbox =3D gtk_vbox_new(FALSE, 0);
> =A0 gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
> - =A0gtk_box_pack_start(GTK_BOX(vbox), paned, TRUE, TRUE, 0);
> + =A0gtk_box_pack_start(GTK_BOX(vbox), paned_, TRUE, TRUE, 0);
> =A0 gtk_container_add(GTK_CONTAINER(window_), vbox);
>
> =A0 ResetOrganizeMenu(true);
> Index: chrome/browser/gtk/bookmark_manager_gtk.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/gtk/bookmark_manager_gtk.h =A0 (revision 22090)
> +++ chrome/browser/gtk/bookmark_manager_gtk.h =A0 (working copy)
> @@ -279,6 +279,7 @@
> =A0 GtkWidget* search_entry_;
> =A0 Profile* profile_;
> =A0 BookmarkModel* model_;
> + =A0GtkWidget* paned_;
> =A0 GtkWidget* left_tree_view_;
> =A0 GtkWidget* right_tree_view_;
>
>
>
>