Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: chrome/browser/gtk/bookmark_manager_gtk.cc

Issue 160422: Remember/restore the bookmark manager pane position. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/bookmark_manager_gtk.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_manager_gtk.cc
===================================================================
--- chrome/browser/gtk/bookmark_manager_gtk.cc (revision 22090)
+++ chrome/browser/gtk/bookmark_manager_gtk.cc (working copy)
@@ -331,6 +331,9 @@
}
BookmarkManagerGtk::~BookmarkManagerGtk() {
+ g_browser_process->local_state()->SetInteger(
+ prefs::kBookmarkManagerSplitLocation,
+ gtk_paned_get_position(GTK_PANED(paned_)));
SaveColumnConfiguration();
model_->RemoveObserver(this);
}
@@ -403,15 +406,26 @@
GtkWidget* left_pane = MakeLeftPane();
GtkWidget* right_pane = MakeRightPane();
- GtkWidget* paned = gtk_hpaned_new();
+ paned_ = gtk_hpaned_new();
+ gtk_paned_pack1(GTK_PANED(paned_), left_pane, FALSE, FALSE);
+ gtk_paned_pack2(GTK_PANED(paned_), right_pane, TRUE, FALSE);
+
// Set the initial position of the pane divider.
- gtk_paned_set_position(GTK_PANED(paned), width / 3);
- gtk_paned_pack1(GTK_PANED(paned), left_pane, FALSE, FALSE);
- gtk_paned_pack2(GTK_PANED(paned), right_pane, TRUE, FALSE);
+ int split_x = g_browser_process->local_state()->GetInteger(
+ prefs::kBookmarkManagerSplitLocation);
+ if (split_x == -1) {
+ split_x = width / 3;
+ } else {
+ int min_split_size = width / 8;
+ // Make sure the user can see both the tree/table.
+ split_x = std::min(width - min_split_size,
+ std::max(min_split_size, split_x));
+ }
+ gtk_paned_set_position(GTK_PANED(paned_), split_x);
GtkWidget* vbox = gtk_vbox_new(FALSE, 0);
gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 0);
- gtk_box_pack_start(GTK_BOX(vbox), paned, TRUE, TRUE, 0);
+ gtk_box_pack_start(GTK_BOX(vbox), paned_, TRUE, TRUE, 0);
gtk_container_add(GTK_CONTAINER(window_), vbox);
ResetOrganizeMenu(true);
« no previous file with comments | « chrome/browser/gtk/bookmark_manager_gtk.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698