Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1604043005: Add instruction veord to the integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix nits. #

Patch Set 3 : Merge into master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/veor.ll View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
4 years, 11 months ago (2016-01-19 23:32:23 UTC) #3
Jim Stichnoth
lgtm
4 years, 11 months ago (2016-01-20 14:21:19 UTC) #4
Karl
4 years, 11 months ago (2016-01-21 18:16:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
53378c145dd13e0c0f0be5275a8f297fb037f18b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698