Add status() DCHECK to ServiceWorkerVersion::StartRequest.

Add status() DCHECK to ServiceWorkerVersion::StartRequest.

All events other than install, activate and message should only be
send to an activated worker, so add a DCHECK for this.

BUG=570820
Committed: https://crrev.com/6df524e9218867e28ea2de2bbbcc9044da7d01e4
Cr-Commit-Position: refs/heads/master@{#370473}

[Marijn Kruisselbrink, 2016-01-20 01:07:25]

mek@chromium.org changed reviewers:
+ nhiroki@chromium.org

[Marijn Kruisselbrink, 2016-01-20 01:07:25]

Addressing a comment from https://codereview.chromium.org/1575283003

[nhiroki, 2016-01-20 04:46:01]

lgtm

https://codereview.chromium.org/1604033003/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_metrics.h (right):

https://codereview.chromium.org/1604033003/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_metrics.h:85: MESSAGE,
Can you update a corresponding UMA enum in histograms.xml?

I know this is not used for recording for now, but it would be better to keep
consistency because we may forget to update when it's actually used.

[Marijn Kruisselbrink, 2016-01-20 17:45:31]

mek@chromium.org changed reviewers:
+ mpearson@chromium.org

[Marijn Kruisselbrink, 2016-01-20 17:45:32]

+mpearson for histograms.xml OWNERS

[Mark P, 2016-01-20 18:02:33]

histograms.xml lgtm

[Marijn Kruisselbrink, 2016-01-20 18:13:02]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-01-20 18:13:03]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1604033003/#ps20001
(title: "update histograms.xml")

[commit-bot: I haz the power, 2016-01-20 18:13:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1604033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1604033003/20001

[commit-bot: I haz the power, 2016-01-20 20:16:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-20 20:17:47]

Description was changed from

==========
Add status() DCHECK to ServiceWorkerVersion::StartRequest.

All events other than install, activate and message should only be
send to an activated worker, so add a DCHECK for this.

BUG=570820
==========

to

==========
Add status() DCHECK to ServiceWorkerVersion::StartRequest.

All events other than install, activate and message should only be
send to an activated worker, so add a DCHECK for this.

BUG=570820

Committed: https://crrev.com/6df524e9218867e28ea2de2bbbcc9044da7d01e4
Cr-Commit-Position: refs/heads/master@{#370473}
==========

[commit-bot: I haz the power, 2016-01-20 20:17:48]

Patchset 2 (id:??) landed as
https://crrev.com/6df524e9218867e28ea2de2bbbcc9044da7d01e4
Cr-Commit-Position: refs/heads/master@{#370473}