Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: content/browser/service_worker/service_worker_version.cc

Issue 1604033003: Add status() DCHECK to ServiceWorkerVersion::StartRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update histograms.xml Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_version.cc
diff --git a/content/browser/service_worker/service_worker_version.cc b/content/browser/service_worker/service_worker_version.cc
index b77ba3b06ec0ab61b2ac67e528e0bd38e8612d57..ea062db6ce88d85273cd16a39dbe6ec505fae639 100644
--- a/content/browser/service_worker/service_worker_version.cc
+++ b/content/browser/service_worker/service_worker_version.cc
@@ -478,6 +478,12 @@ int ServiceWorkerVersion::StartRequest(
OnBeginEvent();
DCHECK_EQ(RUNNING, running_status())
<< "Can only start a request with a running worker.";
+ DCHECK(event_type == ServiceWorkerMetrics::EventType::INSTALL ||
+ event_type == ServiceWorkerMetrics::EventType::ACTIVATE ||
+ event_type == ServiceWorkerMetrics::EventType::MESSAGE ||
+ status() == ACTIVATED)
+ << "Event of type " << static_cast<int>(event_type)
+ << " can only be dispatched to an active worker: " << status();
return AddRequest(error_callback, &custom_requests_, REQUEST_CUSTOM,
event_type);
}
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698