Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 160403002: Add few LOG(ERROR)s when LoadLibrary fails (Closed)

Created:
6 years, 10 months ago by hyunki
Modified:
6 years, 10 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add few LOG(ERROR)s when LoadLibrary fails added log messages when LoadLibrary fails for GLES/EGL libraries. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251287

Patch Set 1 #

Total comments: 2

Patch Set 2 : changed NOTREACHED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/gl/gl_implementation_android.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
hyunki
PTAL.
6 years, 10 months ago (2014-02-12 12:44:52 UTC) #1
hyunki
6 years, 10 months ago (2014-02-12 13:39:21 UTC) #2
no sievers
lgtm https://codereview.chromium.org/160403002/diff/1/ui/gl/gl_implementation_android.cc File ui/gl/gl_implementation_android.cc (right): https://codereview.chromium.org/160403002/diff/1/ui/gl/gl_implementation_android.cc#newcode126 ui/gl/gl_implementation_android.cc:126: NOTIMPLEMENTED() << "InitializeDynamicGLBindings on Android"; NOTREACHED()
6 years, 10 months ago (2014-02-12 17:20:43 UTC) #3
Ken Russell (switch to Gerrit)
LGTM with sievers' feedback addressed.
6 years, 10 months ago (2014-02-12 19:49:21 UTC) #4
piman
lgtm
6 years, 10 months ago (2014-02-12 20:24:23 UTC) #5
hyunki
Thank you for the review. https://codereview.chromium.org/160403002/diff/1/ui/gl/gl_implementation_android.cc File ui/gl/gl_implementation_android.cc (right): https://codereview.chromium.org/160403002/diff/1/ui/gl/gl_implementation_android.cc#newcode126 ui/gl/gl_implementation_android.cc:126: NOTIMPLEMENTED() << "InitializeDynamicGLBindings on ...
6 years, 10 months ago (2014-02-14 02:00:35 UTC) #6
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 10 months ago (2014-02-14 02:00:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/160403002/80001
6 years, 10 months ago (2014-02-14 02:03:16 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 13:35:14 UTC) #9
Message was sent while issue was closed. 
Change committed as 251287

Powered by Google App Engine
This is Rietveld 408576698