Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: ui/gl/gl_implementation_android.cc

Issue 160403002: Add few LOG(ERROR)s when LoadLibrary fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed NOTREACHED Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_implementation_android.cc
diff --git a/ui/gl/gl_implementation_android.cc b/ui/gl/gl_implementation_android.cc
index 190f6692428cecc4779dcce8d9c594eacee5850f..22d5ec63a120d1158e2624604b50ae4f2d747ec6 100644
--- a/ui/gl/gl_implementation_android.cc
+++ b/ui/gl/gl_implementation_android.cc
@@ -57,10 +57,13 @@ bool InitializeStaticGLBindings(GLImplementation implementation) {
switch (implementation) {
case kGLImplementationEGLGLES2: {
base::NativeLibrary gles_library = LoadLibrary("libGLESv2.so");
- if (!gles_library)
+ if (!gles_library) {
+ LOG(ERROR) << "Failed to load libGLESv2.so.";
return false;
+ }
base::NativeLibrary egl_library = LoadLibrary("libEGL.so");
if (!egl_library) {
+ LOG(ERROR) << "Failed to load libEGL.so.";
base::UnloadNativeLibrary(gles_library);
return false;
}
@@ -120,6 +123,7 @@ bool InitializeDynamicGLBindings(GLImplementation implementation,
InitializeDynamicGLBindingsGL(context);
break;
default:
+ NOTREACHED() << "InitializeDynamicGLBindings on Android";
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698