Changing SkDeferredCanvas to use factories for creation

Changing SkDeferredCanvas to use factories for creation

The objective of this change is to remove all calls to 
SkCanvas::setDevice. The factory API is hidden behind
a build flag in order to ease the roll into chromium.

A side-effect of the factory pattern is that it will
no longer be possible to allocate a SkDeferredCanvas on
the stack.  This changes nothing for chrome, but it
impacts skia test programs.

Committed: https://code.google.com/p/skia/source/detail?r=9298

[Justin Novosad, 2013-05-24 21:36:12]

PTAL

[reed1, 2013-05-28 12:55:18]

https://codereview.chromium.org/16040002/diff/1/include/utils/SkDeferredCanvas.h
File include/utils/SkDeferredCanvas.h (right):

https://codereview.chromium.org/16040002/diff/1/include/utils/SkDeferredCanva...
include/utils/SkDeferredCanvas.h:35: #if SK_DEFERRED_CANVAS_USES_FACTORIES
Why do we need to ever hide the new methods?

https://codereview.chromium.org/16040002/diff/1/include/utils/SkDeferredCanva...
include/utils/SkDeferredCanvas.h:39: static SkDeferredCanvas* create(SkDevice*
device);
Static methods are Capitalized.

https://codereview.chromium.org/16040002/diff/1/include/utils/SkDeferredCanva...
include/utils/SkDeferredCanvas.h:39: static SkDeferredCanvas* create(SkDevice*
device);
Do we really need to expose a version that takes a device argument? I see the
surface version (yah!). What is the need for this variant?

Trying to remove devices from our public lexicon

[Justin Novosad, 2013-05-28 14:05:30]

https://codereview.chromium.org/16040002/diff/1/include/utils/SkDeferredCanvas.h
File include/utils/SkDeferredCanvas.h (right):

https://codereview.chromium.org/16040002/diff/1/include/utils/SkDeferredCanva...
include/utils/SkDeferredCanvas.h:39: static SkDeferredCanvas* create(SkDevice*
device);
On 2013/05/28 12:55:18, reed1 wrote:
> Do we really need to expose a version that takes a device argument? I see the
> surface version (yah!). What is the need for this variant?
> 
> Trying to remove devices from our public lexicon

It would require a whole lot of work in our test programs. How about exposing it
just to SK_DEVELOPER builds?

[reed1, 2013-05-28 14:29:01]

Sure, exposing device only for SK_DEVELOPER sounds good... assuming chrome
doesn't enable that :)

[Justin Novosad, 2013-05-28 14:38:12]

New Patch

[reed1, 2013-05-28 16:30:11]

lgtm

[Justin Novosad, 2013-05-28 17:39:15]

Committed patchset #2 manually as r9298 (presubmit successful).