Changing SkDeferredCanvas to use factories for creation

include/utils/SkDeferredCanvas.h

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkDeferredCanvas_DEFINED
 #define SkDeferredCanvas_DEFINED
 
 #include "SkCanvas.h"
 #include "SkPixelRef.h"
 
 class DeferredDevice;
 class SkImage;
 class SkSurface;
 
+#if !defined(SK_DEFERRED_CANVAS_USES_FACTORIES)
+// This is temporary, for rolling the API change into Chromium/Blink
+#define SK_DEFERRED_CANVAS_USES_FACTORIES 0
+#endif
+
 /** \class SkDeferredCanvas
     Subclass of SkCanvas that encapsulates an SkPicture or SkGPipe for deferred
     drawing. The main difference between this class and SkPictureRecord (the
     canvas provided by SkPicture) is that this is a full drop-in replacement
     for SkCanvas, while SkPictureRecord only supports draw operations.
     SkDeferredCanvas will transparently trigger the flushing of deferred
     draw operations when an attempt is made to access the pixel data.
 */
 class SK_API SkDeferredCanvas : public SkCanvas {
 public:
     class NotificationClient;
 
+#if SK_DEFERRED_CANVAS_USES_FACTORIES

[reed1, 2013/05/28 12:55:18]

Why do we need to ever hide the new methods?

+    /** Construct a canvas with the specified device to draw into.
+        @param device Specifies a device for the canvas to draw into.
+     */
+    static SkDeferredCanvas* create(SkDevice* device);

[reed1, 2013/05/28 12:55:18]

Static methods are Capitalized.

[reed1, 2013/05/28 12:55:18]

Do we really need to expose a version that takes a device argument? I see the
surface version (yah!). What is the need for this variant?

Trying to remove devices from our public lexicon

[Justin Novosad, 2013/05/28 14:05:30]

It would require a whole lot of work in our test programs. How about exposing it
just to SK_DEVELOPER builds?

+
+    /** Construct a canvas with the specified surface to draw into.
+        This factory must be used for newImageSnapshot to work.
+        @param surface Specifies a surface for the canvas to draw into.
+     */
+    static SkDeferredCanvas* create(SkSurface* surface);
+#else
+    /** DEPRECATED
+     */
     SkDeferredCanvas();
 
-    /** Construct a canvas with the specified device to draw into.
+    /** DEPRACATED, use create instead
+        Construct a canvas with the specified device to draw into.
         Equivalent to calling default constructor, then setDevice.
         @param device Specifies a device for the canvas to draw into.
     */
     explicit SkDeferredCanvas(SkDevice* device);
 
-    /** Construct a canvas with the specified surface to draw into.
+    /** DEPRECATED, use create instead
+        Construct a canvas with the specified surface to draw into.
         This constructor must be used for newImageSnapshot to work.
         @param surface Specifies a surface for the canvas to draw into.
     */
     explicit SkDeferredCanvas(SkSurface* surface);
+#endif
 
     virtual ~SkDeferredCanvas();
 
-    /**
+    /** DEPRECATED
      *  Specify a device to be used by this canvas. Calling setDevice will
      *  release the previously set device, if any. Takes a reference on the
      *  device.
      *
      *  @param device The device that the canvas will raw into
      *  @return The device argument, for convenience.
      */
     virtual SkDevice* setDevice(SkDevice* device);
 
     /**
@@ skipping 190 matching lines @@
          *  or completely overwritten by the command currently being recorded.
          */
         virtual void skippedPendingDrawCommands() {}
     };
 
 protected:
     virtual SkCanvas* canvasForDrawIter();
     DeferredDevice* getDeferredDevice() const;
 
 private:
+#if SK_DEFERRED_CANVAS_USES_FACTORIES
+    SkDeferredCanvas(DeferredDevice*);
+#endif
+
     void recordedDrawCommand();
     SkCanvas* drawingCanvas() const;
     SkCanvas* immediateCanvas() const;
     bool isFullFrame(const SkRect*, const SkPaint*) const;
     void validate() const;
     void init();
     bool            fDeferredDrawing;
 
     friend class SkDeferredCanvasTester; // for unit testing
     typedef SkCanvas INHERITED;
 };
 
 
 #endif