Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1603893003: Add vstr{s,d} to the integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl
Modified:
4 years, 11 months ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add Dart files. #

Total comments: 2

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -4 lines) Patch
M src/DartARM32/assembler_arm.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 chunk +41 lines, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +6 lines, -1 line 0 comments Download
A tests_lit/assembler/arm32/vstr.ll View 1 2 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
4 years, 11 months ago (2016-01-19 23:24:51 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1603893003/diff/20001/tests_lit/assembler/arm32/vstr.ll File tests_lit/assembler/arm32/vstr.ll (right): https://codereview.chromium.org/1603893003/diff/20001/tests_lit/assembler/arm32/vstr.ll#newcode1 tests_lit/assembler/arm32/vstr.ll:1: ; Show that we know how to translate ...
4 years, 11 months ago (2016-01-19 23:51:27 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as 4a55a602331f96c91be1697db4b27859ac58a270 (tree was closed).
4 years, 11 months ago (2016-01-21 18:02:22 UTC) #6
Karl
4 years, 11 months ago (2016-01-21 18:03:11 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1603893003/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vstr.ll (right):

https://codereview.chromium.org/1603893003/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vstr.ll:1: ; Show that we know how to translate
(floating point) vldr and vstr.
On 2016/01/19 23:51:27, stichnot wrote:
> vldr?  I thought just vstr.

Fixed.

Powered by Google App Engine
This is Rietveld 408576698