third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl - Issue 1603893002: bluetooth: Switch BluetoothGattCharacteristic.value to DataView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

Issue 1603893002: bluetooth: Switch BluetoothGattCharacteristic.value to DataView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetoothValue

Patch Set: Updated tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

index b9edeec88fc9c4bcea02bdc5311dd15eb828cb61..b9a5379268927fda47edfb81caf2ec4815951569 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

@@ -14,12 +14,12 @@

// TODO(ortuno): Add test to make sure service matches the service

// used to call getCharacteristic.

// readonly attribute BluetoothGATTService service;

- readonly attribute UUID uuid;

+ readonly attribute UUID uuid;

readonly attribute BluetoothCharacteristicProperties properties;

- readonly attribute ArrayBuffer? value;

+ readonly attribute DataView? value;

// Promise<BluetoothGATTDescriptor> getDescriptor(BluetoothDescriptorUUID descriptor);

// Promise<sequence<BluetoothGATTDescriptor>> getDescriptors(optional BluetoothDescriptorUUID descriptor);

- [CallWith=ScriptState] Promise<ArrayBuffer> readValue();

+ [CallWith=ScriptState] Promise<DataView> readValue();

[CallWith=ScriptState] Promise<void> writeValue(BufferSource value);

[CallWith=ScriptState] Promise<void> startNotifications();

[CallWith=ScriptState] Promise<void> stopNotifications();