Chromium Code Reviews| Index: third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html |
| diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html b/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html |
| index d21107a0ca5f9307ef29bf8474b4cfb88e24fd2d..bde077971623cb0d15a329a25947f28b031b6f35 100644 |
| --- a/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html |
| +++ b/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html |
| @@ -18,13 +18,8 @@ promise_test(() => { |
| 'readValue', |
| 'characteristicvaluechanged'); |
| }).then(results => { |
| - let read_value = new Uint8Array(results[0]); |
| - let event_value = new Uint8Array(results[1]); |
| - // TODO(ortuno): The ArrayBuffer used to resolve the promise |
| - // should be the same ArrayBuffer as the one saved in the |
| - // characteristic. |
| - // http://crbug.com/543347 |
| - // assert_equals(event.target.value, value); |
|
ortuno
2016/01/19 20:08:23
You should either assert the objects are the same
|
| + let read_value = results[0].buffer; |
| + let event_value = results[1].buffer; |
| assert_array_equals(event_value, read_value); |
| }); |
| }, 'Reading a characteristic should fire an event.'); |
| @@ -41,14 +36,9 @@ promise_test(() => { |
| 'characteristicvaluechanged', |
| 3 /* attach 3 listeners */); |
| }).then(results => { |
| - let read_value = new Uint8Array(results[0]); |
| - let event_values = results.slice(1).map(v => new Uint8Array(v)); |
| + let read_value = results[0].buffer; |
| + let event_values = results.slice(1).map(v => v.buffer); |
| for (let event_value of event_values) { |
| - // TODO(ortuno): The ArrayBuffer used to resolve the promise |
| - // should be the same ArrayBuffer as the one saved in the |
| - // characteristic. |
| - // http://crbug.com/543347 |
| - // assert_equals(event.target.value, value); |
|
ortuno
2016/01/19 20:08:23
Same here.
|
| assert_array_equals(event_value, read_value); |
| } |
| }); |