bluetooth: Switch BluetoothGattCharacteristic.value to DataView

third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/bluetooth/BluetoothGATTCharacteristic.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "core/dom/DOMDataView.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/events/Event.h"
 #include "modules/bluetooth/BluetoothCharacteristicProperties.h"
 #include "modules/bluetooth/BluetoothError.h"
 #include "modules/bluetooth/BluetoothSupplement.h"
 #include "public/platform/modules/bluetooth/WebBluetooth.h"
 
 namespace blink {
 
 namespace {
 
-PassRefPtr<DOMArrayBuffer> ConvertWebVectorToArrayBuffer(
+PassRefPtr<DOMDataView> ConvertWebVectorToDataView(
     const WebVector<uint8_t>& webVector)
 {
     static_assert(sizeof(*webVector.data()) == 1, "uint8_t should be a single byte");
     RefPtr<DOMArrayBuffer> domBuffer = DOMArrayBuffer::create(webVector.data(), webVector.size());
-    return domBuffer;
+    RefPtr<DOMDataView> domDataView = DOMDataView::create(domBuffer, 0, webVector.size());
+    return domDataView;
 }
 
 } // anonymous namespace
 
 BluetoothGATTCharacteristic::BluetoothGATTCharacteristic(ExecutionContext* context, PassOwnPtr<WebBluetoothGATTCharacteristicInit> webCharacteristic)
     : ActiveDOMObject(context)
     , m_webCharacteristic(webCharacteristic)
     , m_stopped(false)
 {
     m_properties = BluetoothCharacteristicProperties::create(m_webCharacteristic->characteristicProperties);
     // See example in Source/platform/heap/ThreadState.h
     ThreadState::current()->registerPreFinalizer(this);
 }
 
 BluetoothGATTCharacteristic* BluetoothGATTCharacteristic::take(ScriptPromiseResolver* resolver, PassOwnPtr<WebBluetoothGATTCharacteristicInit> webCharacteristic)
 {
     if (!webCharacteristic) {
         return nullptr;
     }
     BluetoothGATTCharacteristic* characteristic = new BluetoothGATTCharacteristic(resolver->executionContext(), webCharacteristic);
     // See note in ActiveDOMObject about suspendIfNeeded.
     characteristic->suspendIfNeeded();
     return characteristic;
 }
 
 void BluetoothGATTCharacteristic::setValue(
-    const PassRefPtr<DOMArrayBuffer>& domBuffer)
+    const PassRefPtr<DOMDataView>& domDataView)
 {
-    m_value = domBuffer;
+    m_value = domDataView;
 }
 
 void BluetoothGATTCharacteristic::dispatchCharacteristicValueChanged(
     const WebVector<uint8_t>& value)
 {
-    RefPtr<DOMArrayBuffer> domBuffer = ConvertWebVectorToArrayBuffer(value);
-    this->setValue(domBuffer);
+    RefPtr<DOMDataView> domDataView = ConvertWebVectorToDataView(value);
+    this->setValue(domDataView);
     dispatchEvent(Event::create(EventTypeNames::characteristicvaluechanged));
 }
 
 void BluetoothGATTCharacteristic::stop()
 {
     notifyCharacteristicObjectRemoved();
 }
 
 void BluetoothGATTCharacteristic::dispose()
 {
@@ skipping 32 matching lines @@
 
 class ReadValueCallback : public WebBluetoothReadValueCallbacks {
 public:
     ReadValueCallback(BluetoothGATTCharacteristic* characteristic, ScriptPromiseResolver* resolver) : m_webCharacteristic(characteristic), m_resolver(resolver) {}
 
     void onSuccess(const WebVector<uint8_t>& value) override
     {
         if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
             return;
 
-        RefPtr<DOMArrayBuffer> domBuffer = ConvertWebVectorToArrayBuffer(value);
+        RefPtr<DOMDataView> domDataView = ConvertWebVectorToDataView(value);
         if (m_webCharacteristic) {
-            m_webCharacteristic->setValue(domBuffer);
+            m_webCharacteristic->setValue(domDataView);
         }
-        m_resolver->resolve(domBuffer);
+        m_resolver->resolve(domDataView);
     }
 
     void onError(const WebBluetoothError& e) override
     {
         if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())
             return;
         m_resolver->reject(BluetoothError::take(m_resolver, e));
     }
 
 private:
@@ skipping 54 matching lines @@
 }
 
 DEFINE_TRACE(BluetoothGATTCharacteristic)
 {
     RefCountedGarbageCollectedEventTargetWithInlineData<BluetoothGATTCharacteristic>::trace(visitor);
     ActiveDOMObject::trace(visitor);
     visitor->trace(m_properties);
 }
 
 } // namespace blink