Use registerWeakMembers to manage observer root.

Use registerWeakMembers to manage observer root.

Re-landing after revert:

https://codereview.chromium.org/1600243002

Also fix IntersectionObserver::dispose to not allocate memory, since
it runs during gc.

BUG=540528
R=haraken@chromium.org,dcheng@chromium.org

Committed: https://crrev.com/1e43e0e845776971d80e264073f936f33532d0e3
Cr-Commit-Position: refs/heads/master@{#370079}

[haraken, 2016-01-19 02:49:21]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2016-01-19 02:49:21]

LGTM, but I want to have Sigbjorn take another look.

https://codereview.chromium.org/1603773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/IntersectionObserver.h (right):

https://codereview.chromium.org/1603773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/IntersectionObserver.h:59: void
processWeakRoot(Visitor*);

Nit: processWeakRoot => clearWeakMembers

(We conventionally use the name.)

[szager1, 2016-01-19 03:07:52]

https://codereview.chromium.org/1603773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/IntersectionObserver.h (right):

https://codereview.chromium.org/1603773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/IntersectionObserver.h:59: void
processWeakRoot(Visitor*);
On 2016/01/19 02:49:21, haraken wrote:
> 
> Nit: processWeakRoot => clearWeakMembers
> 
> (We conventionally use the name.)

Done.

[sof, 2016-01-19 06:10:54]

lgtm

https://codereview.chromium.org/1603773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObservation.h (right):

https://codereview.chromium.org/1603773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.h:38: 
nit: remove empty line.

[szager1, 2016-01-19 06:35:19]

https://codereview.chromium.org/1603773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObservation.h (right):

https://codereview.chromium.org/1603773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObservation.h:38: 
On 2016/01/19 06:10:54, sof wrote:
> nit: remove empty line.

Done.

[szager1, 2016-01-19 06:35:38]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-01-19 06:35:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/1603773002/#ps40001
(title: "nit scratched")

[commit-bot: I haz the power, 2016-01-19 06:35:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1603773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1603773002/40001

[commit-bot: I haz the power, 2016-01-19 07:50:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-19 07:51:28]

Description was changed from

==========
Use registerWeakMembers to manage observer root.

Re-landing after revert:

https://codereview.chromium.org/1600243002

Also fix IntersectionObserver::dispose to not allocate memory, since
it runs during gc.

BUG=540528
R=haraken@chromium.org,dcheng@chromium.org
==========

to

==========
Use registerWeakMembers to manage observer root.

Re-landing after revert:

https://codereview.chromium.org/1600243002

Also fix IntersectionObserver::dispose to not allocate memory, since
it runs during gc.

BUG=540528
R=haraken@chromium.org,dcheng@chromium.org

Committed: https://crrev.com/1e43e0e845776971d80e264073f936f33532d0e3
Cr-Commit-Position: refs/heads/master@{#370079}
==========

[commit-bot: I haz the power, 2016-01-19 07:51:29]

Patchset 3 (id:??) landed as
https://crrev.com/1e43e0e845776971d80e264073f936f33532d0e3
Cr-Commit-Position: refs/heads/master@{#370079}