Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1603463006: ExtensionPrefs: remove FixMissingPrefs (Closed)

Created:
4 years, 11 months ago by Marc Treib
Modified:
4 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@depr_migrate_perms
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExtensionPrefs: remove FixMissingPrefs This added kPrefInstallTime for extensions that were installed before the install time pref was introduced, 5 years ago: https://codereview.chromium.org/5213002 BUG=none Committed: https://crrev.com/323cddfd6f5adb394fa9f1e3fb834a639415ed93 Cr-Commit-Position: refs/heads/master@{#370224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M extensions/browser/extension_prefs.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 2 chunks +0 lines, -21 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
Marc Treib
Found one more! I think I'm done now ;)
4 years, 11 months ago (2016-01-18 11:22:36 UTC) #2
Devlin
On 2016/01/18 11:22:36, Marc Treib wrote: > I think I'm done now ;) Dang - ...
4 years, 11 months ago (2016-01-19 18:17:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463006/1
4 years, 11 months ago (2016-01-19 20:41:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-19 22:44:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603463006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603463006/1
4 years, 11 months ago (2016-01-19 22:53:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 23:38:15 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 23:39:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/323cddfd6f5adb394fa9f1e3fb834a639415ed93
Cr-Commit-Position: refs/heads/master@{#370224}

Powered by Google App Engine
This is Rietveld 408576698