Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1589403002: ExtensionPrefs: remove MigratePermissions (Closed)

Created:
4 years, 11 months ago by Marc Treib
Modified:
4 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@depr_disable_reason
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExtensionPrefs: remove MigratePermissions The pref change happened > 4 years ago (https://codereview.chromium.org/7003098), let's assume everything's migrated. BUG=none Committed: https://crrev.com/df09ded9d970e6847779d824faf887575f6c9fea Cr-Commit-Position: refs/heads/master@{#370169}

Patch Set 1 #

Patch Set 2 : update test data #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -64 lines) Patch
M chrome/test/data/extensions/good/Preferences View 1 3 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/extension_prefs.h View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/browser/extension_prefs.cc View 3 chunks +0 lines, -57 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (3 generated)
Marc Treib
Aaand one more. (That's the last one for today, I promise!)
4 years, 11 months ago (2016-01-15 17:05:57 UTC) #2
Devlin
Good find. Let this be an example of a reason to always put a TODO(foo): ...
4 years, 11 months ago (2016-01-15 18:00:59 UTC) #3
Devlin
hit publish too early. Meant to also say "but it looks like you have failing ...
4 years, 11 months ago (2016-01-15 18:01:31 UTC) #4
Marc Treib
On 2016/01/15 18:01:31, Devlin wrote: > hit publish too early. Meant to also say "but ...
4 years, 11 months ago (2016-01-15 18:53:54 UTC) #5
Marc Treib
On 2016/01/15 18:53:54, Marc Treib wrote: > On 2016/01/15 18:01:31, Devlin wrote: > > hit ...
4 years, 11 months ago (2016-01-18 10:37:47 UTC) #6
Devlin
lgtm
4 years, 11 months ago (2016-01-19 18:27:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1589403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1589403002/20001
4 years, 11 months ago (2016-01-19 18:38:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-19 19:48:24 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 19:49:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df09ded9d970e6847779d824faf887575f6c9fea
Cr-Commit-Position: refs/heads/master@{#370169}

Powered by Google App Engine
This is Rietveld 408576698