Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3550)

Unified Diff: demos/src/main/res/values/dimens.xml

Issue 1603383003: color, package and action bar configuration. (Closed) Base URL: https://github.com/GoogleChrome/custom-tabs-client.git@master
Patch Set: Added action bar configuration item. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: demos/src/main/res/values/dimens.xml
diff --git a/demos/src/main/res/values/dimens.xml b/demos/src/main/res/values/dimens.xml
index bdea6d0f821683de715b8556f5748545a45aa080..0ce48409eba6f147dc17ec1aadf93cb35dbda32b 100644
--- a/demos/src/main/res/values/dimens.xml
+++ b/demos/src/main/res/values/dimens.xml
@@ -16,5 +16,10 @@
<!-- Default screen margins, per the Android Design guidelines. -->
<dimen name="activity_horizontal_margin">16dp</dimen>
<dimen name="activity_vertical_margin">16dp</dimen>
- <dimen name="view_vertical_margin">16dp</dimen>
+ <dimen name="view_vertical_margin">10sp</dimen>
+ <dimen name="view_height">50sp</dimen>
Ian Wen 2016/02/09 00:14:16 Which view's height? Dimen's should not be named t
BigBossZhiling 2016/02/09 01:03:12 This literally is the height of all views except t
+ <dimen name="button_width">300sp</dimen>
Ian Wen 2016/02/09 00:14:16 Usually you don't need to specify the button's wid
BigBossZhiling 2016/02/09 01:03:12 For example, for 2 buttons whose text are of diffe
+ <dimen name="button_height">50sp</dimen>
+ <dimen name="button_padding_top">10sp</dimen>
+ <dimen name="spinner_padding_left">15sp</dimen>
</resources>

Powered by Google App Engine
This is Rietveld 408576698