demos/src/main/res/values/dimens.xml - Issue 1603383003: color, package and action bar configuration.

Side by Side Diff: demos/src/main/res/values/dimens.xml

Issue 1603383003: color, package and action bar configuration. (Closed) Base URL: https://github.com/GoogleChrome/custom-tabs-client.git@master

Patch Set: Added action bar configuration item. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« demos/src/main/res/layout/row.xml ('K') | « demos/src/main/res/layout/row.xml ('k') | demos/src/main/res/values/strings.xml » ('j') | shared/src/main/java/org/chromium/customtabsclient/shared/CustomTabsHelper.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!-- Copyright 2015 Google Inc. All Rights Reserved.	1 <!-- Copyright 2015 Google Inc. All Rights Reserved.

2	2

3 Licensed under the Apache License, Version 2.0 (the "License");	3 Licensed under the Apache License, Version 2.0 (the "License");

4 you may not use this file except in compliance with the License.	4 you may not use this file except in compliance with the License.

5 You may obtain a copy of the License at	5 You may obtain a copy of the License at

6	6

7 http://www.apache.org/licenses/LICENSE-2.0	7 http://www.apache.org/licenses/LICENSE-2.0

8	8

9 Unless required by applicable law or agreed to in writing, software	9 Unless required by applicable law or agreed to in writing, software

10 distributed under the License is distributed on an "AS IS" BASIS,	10 distributed under the License is distributed on an "AS IS" BASIS,

11 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.	11 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

12 See the License for the specific language governing permissions and	12 See the License for the specific language governing permissions and

13 limitations under the License.	13 limitations under the License.

14 -->	14 -->

15 <resources>	15 <resources>

16 <!-- Default screen margins, per the Android Design guidelines. -->	16 <!-- Default screen margins, per the Android Design guidelines. -->

17 <dimen name="activity_horizontal_margin">16dp</dimen>	17 <dimen name="activity_horizontal_margin">16dp</dimen>

18 <dimen name="activity_vertical_margin">16dp</dimen>	18 <dimen name="activity_vertical_margin">16dp</dimen>

19 <dimen name="view_vertical_margin">16dp</dimen>	19 <dimen name="view_vertical_margin">10sp</dimen>

	20 <dimen name="view_height">50sp</dimen>
	Ian Wen 2016/02/09 00:14:16 Which view's height? Dimen's should not be named t Which view's height? Dimen's should not be named too vaguely. BigBossZhiling 2016/02/09 01:03:12 This literally is the height of all views except t Show quoted text On 2016/02/09 00:14:16, Ian Wen wrote: > Which view's height? Dimen's should not be named too vaguely. This literally is the height of all views except the image. Each row, no matter whether it is spinner, checkbox, button, they all have this height. I was thinking that it should look more uniform.
	21 <dimen name="button_width">300sp</dimen>
	Ian Wen 2016/02/09 00:14:16 Usually you don't need to specify the button's wid Usually you don't need to specify the button's width or height. Wrap content would just do the magic. Why do you need it here? BigBossZhiling 2016/02/09 01:03:12 For example, for 2 buttons whose text are of diffe Show quoted text On 2016/02/09 00:14:16, Ian Wen wrote: > Usually you don't need to specify the button's width or height. Wrap content > would just do the magic. Why do you need it here? For example, for 2 buttons whose text are of different length, I think if I do wrap content, then the buttons will have different widths.
	22 <dimen name="button_height">50sp</dimen>

	23 <dimen name="button_padding_top">10sp</dimen>

	24 <dimen name="spinner_padding_left">15sp</dimen>

20 </resources>	25 </resources>

OLD	NEW