Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1603343003: Fix caca backend build. (Closed)

Created:
4 years, 11 months ago by lgombos
Modified:
4 years, 11 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix caca backend build. A previous patch has replaced Pass() with std::move in ui/ozone, but missed two sites under caca/. BUG=557422 Committed: https://crrev.com/a31b8aa25b9db0ee6781967e1a603ff060ef8adf Cr-Commit-Position: refs/heads/master@{#370409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/ozone/platform/caca/caca_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/caca/ozone_platform_caca.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
lgombos
The caca build has regressed as a result of https://codereview.chromium.org/1528373002/ . This CL resolves the ...
4 years, 11 months ago (2016-01-20 16:07:20 UTC) #3
spang
lgtm
4 years, 11 months ago (2016-01-20 16:31:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1603343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1603343003/1
4 years, 11 months ago (2016-01-20 16:32:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 16:42:12 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a31b8aa25b9db0ee6781967e1a603ff060ef8adf Cr-Commit-Position: refs/heads/master@{#370409}
4 years, 11 months ago (2016-01-20 16:44:12 UTC) #10
mkollaro
4 years, 11 months ago (2016-01-21 14:38:41 UTC) #11
Message was sent while issue was closed.
Sorry for the mistake, I'll try to check it better next time.

Powered by Google App Engine
This is Rietveld 408576698